Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1144543008: Check last modification time on overinstall for all dev builds. (Closed)

Created:
5 years, 7 months ago by grt (UTC plus 2)
Modified:
5 years, 7 months ago
Reviewers:
brucedawson
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, robertshield
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check last modification time on overinstall for all dev builds. This makes the build/test cycle easier for Release builds. BUG=none R=brucedawson@chromium.org Committed: https://crrev.com/cf06ae59a8f2c350d8556b3a83a5c14a7f1142e9 Cr-Commit-Position: refs/heads/master@{#330558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/installer/util/duplicate_tree_detector.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
grt (UTC plus 2)
This should ease your life a bit.
5 years, 7 months ago (2015-05-19 15:02:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144543008/1
5 years, 7 months ago (2015-05-19 15:02:56 UTC) #3
grt (UTC plus 2)
+CC robertshield
5 years, 7 months ago (2015-05-19 15:03:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-19 16:57:10 UTC) #6
brucedawson
Yes! That should smooth my testing process nicely. Thanks. lgtm
5 years, 7 months ago (2015-05-19 17:28:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144543008/1
5 years, 7 months ago (2015-05-19 18:04:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 18:10:56 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 18:11:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf06ae59a8f2c350d8556b3a83a5c14a7f1142e9
Cr-Commit-Position: refs/heads/master@{#330558}

Powered by Google App Engine
This is Rietveld 408576698