media: Update MediaCodecBridge to use the new log.

media: Update MediaCodecBridge to use the new log.

BUG=472152
Committed: https://crrev.com/fb06a495c5877601435366f37cb639642e851e84
Cr-Commit-Position: refs/heads/master@{#330240}

[xhwang, 2015-05-15 20:52:28]

xhwang@chromium.org changed reviewers:
+ qinmin@chromium.org

[xhwang, 2015-05-15 20:52:28]

One line change. PTAL. See bug for background.

[qinmin, 2015-05-15 23:47:45]

lgtm

[xhwang, 2015-05-15 23:53:53]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2015-05-15 23:55:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144543005/1

[commit-bot: I haz the power, 2015-05-16 00:02:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-18 11:29:33]

Patchset 1 (id:??) landed as
https://crrev.com/fb06a495c5877601435366f37cb639642e851e84
Cr-Commit-Position: refs/heads/master@{#330240}

[dgn, 2015-05-18 14:16:57]

dgn@chromium.org changed reviewers:
+ dgn@chromium.org

[dgn, 2015-05-18 14:16:57]

Thanks for the help! 
I made a few comments that could be useful for the next similar patches.
Ideally, migrating the logger should be done over the whole package, and would
enable controlling logs for that whole package via commands like `adb shell
setprop "log.tag.cr.Media" VERBOSE`

(see
https://chromium.googlesource.com/chromium/src/+/master/base/android/java/src...)

https://codereview.chromium.org/1144543005/diff/1/media/base/android/java/src...
File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
(right):

https://codereview.chromium.org/1144543005/diff/1/media/base/android/java/src...
media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:35: private
static final String TAG = "MediaCodecBridge";
The tag should look like "cr.Media"

https://codereview.chromium.org/1144543005/diff/1/media/base/android/java/src...
media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:232:
Log.w(TAG, "getDefaultCodecName: Failed to create MediaCodec: "
String formatting can be used:

Log.w(TAG, "getDefaultCodecName: Failed to create MediaCodec: %s, direction:
%d", mime, direction, e);

[xhwang, 2015-05-18 16:32:08]

On 2015/05/18 14:16:57, dgn wrote:
> Thanks for the help! 
> I made a few comments that could be useful for the next similar patches.
> Ideally, migrating the logger should be done over the whole package, and would
> enable controlling logs for that whole package via commands like `adb shell
> setprop "log.tag.cr.Media" VERBOSE`
> 
> (see
>
https://chromium.googlesource.com/chromium/src/+/master/base/android/java/src...)
> 
>
https://codereview.chromium.org/1144543005/diff/1/media/base/android/java/src...
> File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
> (right):
> 
>
https://codereview.chromium.org/1144543005/diff/1/media/base/android/java/src...
> media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:35:
private
> static final String TAG = "MediaCodecBridge";
> The tag should look like "cr.Media"
> 
>
https://codereview.chromium.org/1144543005/diff/1/media/base/android/java/src...
> media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:232:
> Log.w(TAG, "getDefaultCodecName: Failed to create MediaCodec: "
> String formatting can be used:
> 
> Log.w(TAG, "getDefaultCodecName: Failed to create MediaCodec: %s, direction:
> %d", mime, direction, e);

Thanks for the info! I filed http://crbug.com/489318 to track this work.