Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1144543004: Reland [Sync] Refactoring polling to be reliable. (Closed)

Created:
5 years, 7 months ago by Nicolas Zea
Modified:
5 years, 7 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland [Sync] Refactoring polling to be reliable. This is a reland of https://codereview.chromium.org/1132013004/ Polling is now an important component of sync health, as it can sometimes be the only time we'll query for certain datatypes. As such, the following has changed: - Polls that fail will be retried (with backoff). - As such, the logic to force a poll after an auth error isn't needed anymore - The last successful poll time will be persisted in the sync prefs. - On startup, schedule the first poll for last_poll_time + poll_interval (or Now(), whichever is latest). - Receiving a new poll interval from the server will update the poll timer - The poll timer is now a one shot timer, and only restarts on success - Some code cleanup to make the above more straightforward BUG=482154 Committed: https://crrev.com/b1133ac9da61c61238ddc112099cc9fbd883853e Cr-Commit-Position: refs/heads/master@{#330024}

Patch Set 1 #

Patch Set 2 : Full patch #

Patch Set 3 : Diff from previous #

Patch Set 4 : Full patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+640 lines, -475 lines) Patch
M chrome/browser/sync/glue/sync_backend_host_core.h View 1 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_core.cc View 1 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.cc View 1 3 2 chunks +4 lines, -1 line 0 comments Download
M components/sync_driver/pref_names.h View 1 3 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/pref_names.cc View 1 3 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync_driver/sync_prefs.h View 1 3 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync_driver/sync_prefs.cc View 1 3 3 chunks +13 lines, -0 lines 0 comments Download
M sync/engine/sync_scheduler.h View 1 3 1 chunk +3 lines, -2 lines 0 comments Download
M sync/engine/sync_scheduler_impl.h View 1 3 4 chunks +9 lines, -13 lines 0 comments Download
M sync/engine/sync_scheduler_impl.cc View 1 2 3 17 chunks +110 lines, -91 lines 0 comments Download
M sync/engine/sync_scheduler_unittest.cc View 1 2 3 56 chunks +172 lines, -111 lines 0 comments Download
M sync/engine/syncer.h View 1 2 3 4 chunks +34 lines, -21 lines 0 comments Download
M sync/engine/syncer.cc View 1 3 6 chunks +16 lines, -2 lines 0 comments Download
M sync/engine/syncer_unittest.cc View 1 2 3 174 chunks +210 lines, -209 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer_unittest.cc View 1 3 1 chunk +1 line, -0 lines 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot.h View 1 3 3 chunks +3 lines, -0 lines 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot.cc View 1 3 3 chunks +6 lines, -0 lines 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot_unittest.cc View 1 3 1 chunk +1 line, -0 lines 0 comments Download
M sync/internal_api/public/sync_manager.h View 1 3 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/public/test/fake_sync_manager.h View 1 3 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl.h View 1 3 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 3 4 chunks +6 lines, -4 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 3 4 chunks +4 lines, -4 lines 0 comments Download
M sync/internal_api/sync_rollback_manager.h View 1 3 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/sync_rollback_manager.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_rollback_manager_base.h View 1 3 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/sync_rollback_manager_base.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_rollback_manager_unittest.cc View 1 3 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/test/fake_sync_manager.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M sync/sessions/status_controller.h View 1 3 2 chunks +13 lines, -1 line 0 comments Download
M sync/sessions/status_controller.cc View 1 3 1 chunk +4 lines, -0 lines 0 comments Download
M sync/sessions/sync_session.cc View 1 3 1 chunk +1 line, -0 lines 0 comments Download
M sync/test/engine/fake_sync_scheduler.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M sync/test/engine/fake_sync_scheduler.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/sync_client.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Nicolas Zea
Pavel, could you take a look again? Patchset 1 contains the diff from the previously ...
5 years, 7 months ago (2015-05-14 20:53:03 UTC) #2
Nicolas Zea
Actually, you can hold off on reviewing. I mixed up the version of the patch ...
5 years, 7 months ago (2015-05-14 22:59:09 UTC) #3
Nicolas Zea
Ok, PTAL again. Patchset 3 has the diff from the previously LGTMd CL.
5 years, 7 months ago (2015-05-14 23:26:49 UTC) #4
pavely
lgtm
5 years, 7 months ago (2015-05-15 00:20:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144543004/60001
5 years, 7 months ago (2015-05-15 00:22:17 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-15 02:23:18 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 02:23:57 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b1133ac9da61c61238ddc112099cc9fbd883853e
Cr-Commit-Position: refs/heads/master@{#330024}

Powered by Google App Engine
This is Rietveld 408576698