|
Reland [Sync] Refactoring polling to be reliable.
This is a reland of https://codereview.chromium.org/1132013004/
Polling is now an important component of sync health, as it can sometimes be
the only time we'll query for certain datatypes. As such, the following
has changed:
- Polls that fail will be retried (with backoff).
- As such, the logic to force a poll after an auth error isn't needed anymore
- The last successful poll time will be persisted in the sync prefs.
- On startup, schedule the first poll for last_poll_time + poll_interval
(or Now(), whichever is latest).
- Receiving a new poll interval from the server will update the poll timer
- The poll timer is now a one shot timer, and only restarts on success
- Some code cleanup to make the above more straightforward
BUG= 482154
Committed: https://crrev.com/b1133ac9da61c61238ddc112099cc9fbd883853e
Cr-Commit-Position: refs/heads/master@{#330024}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+640 lines, -475 lines) |
Patch |
 |
M |
chrome/browser/sync/glue/sync_backend_host_core.h
|
View
|
1
3
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/sync_backend_host_core.cc
|
View
|
1
3
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/sync_backend_host_impl.cc
|
View
|
1
3
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/sync_driver/pref_names.h
|
View
|
1
3
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
components/sync_driver/pref_names.cc
|
View
|
1
3
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/sync_driver/sync_prefs.h
|
View
|
1
3
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/sync_driver/sync_prefs.cc
|
View
|
1
3
|
3 chunks |
+13 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sync/engine/sync_scheduler.h
|
View
|
1
3
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sync/engine/sync_scheduler_impl.h
|
View
|
1
3
|
4 chunks |
+9 lines, -13 lines |
0 comments
|
Download
|
 |
M |
sync/engine/sync_scheduler_impl.cc
|
View
|
1
2
3
|
17 chunks |
+110 lines, -91 lines |
0 comments
|
Download
|
 |
M |
sync/engine/sync_scheduler_unittest.cc
|
View
|
1
2
3
|
56 chunks |
+172 lines, -111 lines |
0 comments
|
Download
|
 |
M |
sync/engine/syncer.h
|
View
|
1
2
3
|
4 chunks |
+34 lines, -21 lines |
0 comments
|
Download
|
 |
M |
sync/engine/syncer.cc
|
View
|
1
3
|
6 chunks |
+16 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sync/engine/syncer_unittest.cc
|
View
|
1
2
3
|
174 chunks |
+210 lines, -209 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/js_sync_manager_observer_unittest.cc
|
View
|
1
3
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/sessions/sync_session_snapshot.h
|
View
|
1
3
|
3 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/sessions/sync_session_snapshot.cc
|
View
|
1
3
|
3 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/sessions/sync_session_snapshot_unittest.cc
|
View
|
1
3
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/sync_manager.h
|
View
|
1
3
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/test/fake_sync_manager.h
|
View
|
1
3
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_manager_impl.h
|
View
|
1
3
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_manager_impl.cc
|
View
|
1
3
|
4 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_manager_impl_unittest.cc
|
View
|
1
3
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_rollback_manager.h
|
View
|
1
3
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_rollback_manager.cc
|
View
|
1
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_rollback_manager_base.h
|
View
|
1
3
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_rollback_manager_base.cc
|
View
|
1
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_rollback_manager_unittest.cc
|
View
|
1
3
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/test/fake_sync_manager.cc
|
View
|
1
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/sessions/status_controller.h
|
View
|
1
3
|
2 chunks |
+13 lines, -1 line |
0 comments
|
Download
|
 |
M |
sync/sessions/status_controller.cc
|
View
|
1
3
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sync/sessions/sync_session.cc
|
View
|
1
3
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
sync/test/engine/fake_sync_scheduler.h
|
View
|
1
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/test/engine/fake_sync_scheduler.cc
|
View
|
1
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/tools/sync_client.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 9 (2 generated)
|