Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1144513003: Revert of Revert of Use |IsOriginSecure| for mark-HTTP-nonsecure field trial (Closed)

Created:
5 years, 7 months ago by sergeyv
Modified:
5 years, 7 months ago
Reviewers:
meacer, estark
CC:
chromium-reviews, palmer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Use |IsOriginSecure| for mark-HTTP-nonsecure field trial (patchset #1 id:1 of https://codereview.chromium.org/1130843005/) Reason for revert: The initial patch was relanded: https://codereview.chromium.org/1124383007/ Original issue's description: > Revert of Use |IsOriginSecure| for mark-HTTP-nonsecure field trial (patchset #1 id:1 of https://codereview.chromium.org/1143503003/) > > Reason for revert: > Android Tests dbg bot is failing: > http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg) > > The reason of this failure is following patch: https://codereview.chromium.org/1123943002/ > > I had to revert this patch because it is a follow up. > > Original issue's description: > > Use |IsOriginSecure| for mark-HTTP-nonsecure field trial > > > > When the flag or field trial is set such that non-secure origins will be > > marked as dubious/non-secure, use |IsOriginSecure| to determine whether > > an origin is non-secure, instead of simply treating http:// and ftp:// > > as non-secure. This means that http://nytimes.com will be marked as > > dubious/non-secure, but not http://localhost (for example). > > > > BUG=487499 > > TEST=Enable the "Mark non-secure as non-secure" flag in > > chrome://flags. Visit http://nytimes.com and observe that the lock icon > > is red and crossed out. Visit an http:// URL on localhost and observe > > that the lock icon is neutral. > > > > Committed: https://crrev.com/5f99677ac4f9b8180ee7fd2f0d5c85e91828a951 > > Cr-Commit-Position: refs/heads/master@{#329774} > > TBR=meacer@chromium.org,estark@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=487499 > > Committed: https://crrev.com/236d015aa9bf3f61ece3e32c8af40fc1b9153727 > Cr-Commit-Position: refs/heads/master@{#329826} TBR=meacer@chromium.org,estark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487499 Committed: https://crrev.com/cf038f5cd909009dbecdc2479bfc3b1b22b86d98 Cr-Commit-Position: refs/heads/master@{#329834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ssl/connection_security_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sergeyv
Created Revert of Revert of Use |IsOriginSecure| for mark-HTTP-nonsecure field trial
5 years, 7 months ago (2015-05-14 12:25:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144513003/1
5 years, 7 months ago (2015-05-14 12:25:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 12:26:30 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 12:27:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf038f5cd909009dbecdc2479bfc3b1b22b86d98
Cr-Commit-Position: refs/heads/master@{#329834}

Powered by Google App Engine
This is Rietveld 408576698