Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 11445038: Revert changes to have ExtensionService notify ThemeService directly for themes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge error Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.h ('k') | chrome/browser/themes/theme_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 83e1a881fedeb66068649a09d60a756e5bce9af9..2ac4a028511c33cae40d2723b6df4f6392e1914d 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -2550,20 +2550,6 @@ void ExtensionService::FinishInstallation(const Extension* extension) {
AddExtension(extension);
-#if defined(ENABLE_THEMES)
- // We do this here since AddExtension() is always called on browser
- // startup, and we only really care about the last theme installed.
- // If that ever changes and we have to move this code somewhere
- // else, it should be somewhere that's not in the startup path.
- if (extension->is_theme() && extensions_.GetByID(extension->id())) {
- DCHECK_EQ(extensions_.GetByID(extension->id()), extension);
- // Now that the theme extension is visible from outside the
- // ExtensionService, notify the ThemeService about the
- // newly-installed theme.
- ThemeServiceFactory::GetForProfile(profile_)->SetTheme(extension);
- }
-#endif
-
// If this is a new external extension that was disabled, alert the user
// so he can reenable it. We do this last so that it has already been
// added to our list of extensions.
« no previous file with comments | « chrome/browser/extensions/extension_service.h ('k') | chrome/browser/themes/theme_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698