Better error messages for dependency conflicts.

Better error messages for dependency conflicts.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=15768

[Bob Nystrom, 2012-12-06 00:37:13]

Fixes http://code.google.com/p/dart/issues/detail?id=5971 and then some.

[nweiz, 2012-12-06 00:58:55]

lgtm

https://codereview.chromium.org/11445034/diff/1/utils/pub/version_solver.dart
File utils/pub/version_solver.dart (right):

https://codereview.chromium.org/11445034/diff/1/utils/pub/version_solver.dart...
utils/pub/version_solver.dart:626: /// Returns the name of a package whose
constraint source and description
"constraint" -> ""?

https://codereview.chromium.org/11445034/diff/1/utils/pub/version_solver.dart...
utils/pub/version_solver.dart:662: buffer.add("Package '$package' has no
versions that match $constraint derived from:\n");
Long line

https://codereview.chromium.org/11445034/diff/1/utils/pub/version_solver.dart...
utils/pub/version_solver.dart:705: buffer.add("Shared dependency version
conflict on '$package':\n");
I don't think "shared dependency version conflict" will mean a whole lot to most
of our users. Maybe "incompatible version constraints"? Similar issue with the
other error messages below.

https://codereview.chromium.org/11445034/diff/1/utils/tests/pub/version_solve...
File utils/tests/pub/version_solver_test.dart (right):

https://codereview.chromium.org/11445034/diff/1/utils/tests/pub/version_solve...
utils/tests/pub/version_solver_test.dart:22: Matcher noVersion(List<String>
packages) {
I think the unittest style would have this be "isNoVersion" or
"isNoVersionException".

[Bob Nystrom, 2012-12-06 17:44:40]

Thanks!

https://codereview.chromium.org/11445034/diff/1/utils/pub/version_solver.dart
File utils/pub/version_solver.dart (right):

https://codereview.chromium.org/11445034/diff/1/utils/pub/version_solver.dart...
utils/pub/version_solver.dart:626: /// Returns the name of a package whose
constraint source and description
On 2012/12/06 00:58:55, nweiz wrote:
> "constraint" -> ""?

It returns the name of the depender, and it's not the depender's source and
description that have to match, it's the depender's constraint's source and
description.

https://codereview.chromium.org/11445034/diff/1/utils/pub/version_solver.dart...
utils/pub/version_solver.dart:662: buffer.add("Package '$package' has no
versions that match $constraint derived from:\n");
On 2012/12/06 00:58:55, nweiz wrote:
> Long line

Done.

https://codereview.chromium.org/11445034/diff/1/utils/pub/version_solver.dart...
utils/pub/version_solver.dart:705: buffer.add("Shared dependency version
conflict on '$package':\n");
On 2012/12/06 00:58:55, nweiz wrote:
> I don't think "shared dependency version conflict" will mean a whole lot to
most
> of our users. Maybe "incompatible version constraints"? Similar issue with the
> other error messages below.

Done.

[nweiz, 2012-12-06 19:43:10]

https://codereview.chromium.org/11445034/diff/1/utils/pub/version_solver.dart
File utils/pub/version_solver.dart (right):

https://codereview.chromium.org/11445034/diff/1/utils/pub/version_solver.dart...
utils/pub/version_solver.dart:626: /// Returns the name of a package whose
constraint source and description
On 2012/12/06 17:44:41, Bob Nystrom wrote:
> On 2012/12/06 00:58:55, nweiz wrote:
> > "constraint" -> ""?
> 
> It returns the name of the depender, and it's not the depender's source and
> description that have to match, it's the depender's constraint's source and
> description.

Then maybe "constraint's"?