NTP5: Reuse insertion/removal animations for Apps.

chrome/browser/resources/ntp_search/new_tab.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview New tab page
  * This is the main code for the new tab page. NewTabView manages page list,
  * dot list and handles apps pages callbacks from backend. It also handles
  * the layout of the Bottom Panel and the global UI states of the New Tab Page.
  */
@@ skipping 409 matching lines @@
      *
      * Note that calls to this function can occur at any time, not just in
      * response to a getApps request. For example, when a user
      * installs/uninstalls an app on another synchronized devices.
      * @param {Object} data An object with all the data on available
      *        applications.
      */
     getAppsCallback: function(data) {
       assert(loadTimeData.getBoolean('showApps'));
 
-      var page = this.appsPage;
-      var state = page && page.getTileRepositioningState();

[Dan Beam, 2012/12/05 18:40:44]

^ so why is all this logic being removed?

[pedro (no code reviews), 2012/12/05 20:03:55]

This logic was placed in the wrong spot. It has been moved to the proper place
inside apps_page.js.

-      if (state) {
-        if (state.isRemoving)
-          page.animateTileRemoval(state.index, data);
-        else
-          page.animateTileRestoration(state.index, data);
-
-        page.resetTileRepositioningState();
-        return;
-      }
-
       var startTime = Date.now();
 
-      if (page)
-        page.removeAllTiles();
-
       // Get the array of apps and add any special synthesized entries.
       var apps = data.apps;
 
       // Sort alphabetically.
       apps.sort(function(a, b) {
         return a.title.toLocaleLowerCase() > b.title.toLocaleLowerCase() ? 1 :
           a.title.toLocaleLowerCase() < b.title.toLocaleLowerCase() ? -1 : 0;
       });
 
       // An app to animate (in case it was just installed).
       var highlightApp;
 
       // Add the apps, creating pages as necessary.
-      this.appendTilePage(new ntp.AppsPage(),
-          loadTimeData.getString('appDefaultPageName'));
+      var page = new ntp.AppsPage();
+      page.setDataList(apps, false);
+
+      this.appendTilePage(page, loadTimeData.getString('appDefaultPageName'));
       for (var i = 0; i < apps.length; i++) {
         var app = apps[i];
         if (app.id == this.highlightAppId)
           highlightApp = app;
         else
           this.appsPage.insertApp(app, false);
       }
 
       if (highlightApp)
         this.appAdded(highlightApp, true);
@@ skipping 684 matching lines @@
     setMostVisitedPages: setMostVisitedPages,
     setRecentlyClosedTabs: setRecentlyClosedTabs,
     showNotification: showNotification,
     themeChanged: themeChanged,
   };
 });
 
 document.addEventListener('DOMContentLoaded', ntp.onLoad);
 
 var toCssPx = cr.ui.toCssPx;