Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5894)

Unified Diff: chrome/browser/ui/webui/sync_setup_handler_unittest.cc

Issue 11445002: Sync user's custom spellcheck dictionary (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Add browser tests for dictionary change notifications in settings Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_setup_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/sync_setup_handler_unittest.cc b/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
index 84d2bfcbc6314debd2fadd0a6072f46151af52c5..14af9c96de993602a9233bb882460299be0de8cc 100644
--- a/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
+++ b/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
@@ -98,6 +98,7 @@ std::string GetConfiguration(const DictionaryValue* extra_values,
result.SetBoolean("appsSynced", types.Has(syncer::APPS));
result.SetBoolean("autofillSynced", types.Has(syncer::AUTOFILL));
result.SetBoolean("bookmarksSynced", types.Has(syncer::BOOKMARKS));
+ result.SetBoolean("dictionarySynced", types.Has(syncer::DICTIONARY));
result.SetBoolean("extensionsSynced", types.Has(syncer::EXTENSIONS));
result.SetBoolean("passwordsSynced", types.Has(syncer::PASSWORDS));
result.SetBoolean("preferencesSynced", types.Has(syncer::PREFERENCES));
@@ -197,6 +198,7 @@ void CheckConfigDataTypeArguments(DictionaryValue* dictionary,
CheckBool(dictionary, "appsSynced", types.Has(syncer::APPS));
CheckBool(dictionary, "autofillSynced", types.Has(syncer::AUTOFILL));
CheckBool(dictionary, "bookmarksSynced", types.Has(syncer::BOOKMARKS));
+ CheckBool(dictionary, "dictionarySynced", types.Has(syncer::DICTIONARY));
CheckBool(dictionary, "extensionsSynced", types.Has(syncer::EXTENSIONS));
CheckBool(dictionary, "passwordsSynced", types.Has(syncer::PASSWORDS));
CheckBool(dictionary, "preferencesSynced", types.Has(syncer::PREFERENCES));
@@ -1095,6 +1097,7 @@ TEST_P(SyncSetupHandlerTest, ShowSetupSyncEverything) {
CheckBool(dictionary, "appsRegistered", true);
CheckBool(dictionary, "autofillRegistered", true);
CheckBool(dictionary, "bookmarksRegistered", true);
+ CheckBool(dictionary, "dictionaryRegistered", false);
CheckBool(dictionary, "extensionsRegistered", true);
CheckBool(dictionary, "passwordsRegistered", true);
CheckBool(dictionary, "preferencesRegistered", true);

Powered by Google App Engine
This is Rietveld 408576698