Sync user's custom spellcheck dictionary

chrome/browser/sync/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service.h"
 
 #include <cstddef>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 1267 matching lines @@
   if (!HasSyncSetupCompleted() ||
       sync_everything != sync_prefs_.HasKeepEverythingSynced()) {
     UMA_HISTOGRAM_BOOLEAN("Sync.SyncEverything", sync_everything);
   }
 
   // Only log the data types that are shown in the sync settings ui.
   const syncer::ModelType model_types[] = {
     syncer::APPS,
     syncer::AUTOFILL,
     syncer::BOOKMARKS,
+    syncer::DICTIONARY,

[Nicolas Zea, 2013/01/02 23:12:15]

Do we want Dictionary to be a separately selectable datatype? I forget if we
have discussed this already or not, but it seems to me it makes sense to tie
this to the PREFERENCES datatype, in the same way as SEARCH_ENGINES is tied to
it.

[please use gerrit instead, 2013/01/04 23:30:50]

I do not recall this discussion, but it's a good idea. I've moved DICTIONARY
under PREFERENCES.

[groby-ooo-7-16, 2013/01/07 19:02:14]

Can't speak to the pros/cons, but I'd like to point out that dictionary data is
independent of system preferences. It's user created data, not a preference.

(I'm not sure if that should influence the discussion, since I'm not familiar
enough with syncing)

On 2013/01/04 23:30:50, Rouslan Solomakhin wrote:

[Nicolas Zea, 2013/01/07 19:07:41]

The user selectable option is actually called "Settings", and it enables
PREFERENCES, and by virtue of that SEARCH ENGINES. My point is that this seems
to me like it should fall under "Settings", and therefore be auto enabled if
PREFERENCES is enabled.

This isn't meant to imply that the dictionary is implemented via preferences.

     syncer::EXTENSIONS,
     syncer::PASSWORDS,
     syncer::PREFERENCES,
     syncer::SESSIONS,
     syncer::THEMES,
     syncer::TYPED_URLS
   };
 
   const browser_sync::user_selectable_type::UserSelectableSyncType
       user_selectable_types[] = {
     browser_sync::user_selectable_type::APPS,
     browser_sync::user_selectable_type::AUTOFILL,
     browser_sync::user_selectable_type::BOOKMARKS,
+    browser_sync::user_selectable_type::DICTIONARY,
     browser_sync::user_selectable_type::EXTENSIONS,
     browser_sync::user_selectable_type::PASSWORDS,
     browser_sync::user_selectable_type::PREFERENCES,
     browser_sync::user_selectable_type::SESSIONS,
     browser_sync::user_selectable_type::THEMES,
     browser_sync::user_selectable_type::TYPED_URLS
   };
 
-  COMPILE_ASSERT(20 == syncer::MODEL_TYPE_COUNT, UpdateCustomConfigHistogram);
+  COMPILE_ASSERT(21 == syncer::MODEL_TYPE_COUNT, UpdateCustomConfigHistogram);
   COMPILE_ASSERT(arraysize(model_types) ==
                  browser_sync::user_selectable_type::SELECTABLE_DATATYPE_COUNT,
                  UpdateCustomConfigHistogram);
   COMPILE_ASSERT(arraysize(model_types) == arraysize(user_selectable_types),
                  UpdateCustomConfigHistogram);
 
   if (!sync_everything) {
     const syncer::ModelTypeSet current_types = GetPreferredDataTypes();
     for (size_t i = 0; i < arraysize(model_types); ++i) {
       const syncer::ModelType type = model_types[i];
@@ skipping 591 matching lines @@
   // See http://stackoverflow.com/questions/6224121/is-new-this-myclass-undefined-behaviour-after-directly-calling-the-destru.
   ProfileSyncService* old_this = this;
   this->~ProfileSyncService();
   new(old_this) ProfileSyncService(
       new ProfileSyncComponentsFactoryImpl(profile,
                                            CommandLine::ForCurrentProcess()),
       profile,
       signin,
       behavior);
 }