Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1144493003: Extract //device/usb mocks so that they can be shared. (Closed)

Created:
5 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 7 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract //device/usb mocks so that they can be shared. A number of browser and unit tests use mocks of the UsbService, UsbDevice and UsbDeviceHandle classes. This change de-duplicates them. Committed: https://crrev.com/cf9be26f35fa706d770ae59dd6d185aed84edc17 Cr-Commit-Position: refs/heads/master@{#329856}

Patch Set 1 #

Patch Set 2 : Fix Android and GN builds. #

Patch Set 3 : Mark mocks target as testonly. #

Patch Set 4 : Fix Android and GN builds for real. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -187 lines) Patch
M chrome/browser/extensions/api/device_permissions_manager_unittest.cc View 6 chunks +12 lines, -41 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/device_tests.gyp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M device/usb/BUILD.gn View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A device/usb/mock_usb_device.h View 1 chunk +36 lines, -0 lines 0 comments Download
A device/usb/mock_usb_device.cc View 1 chunk +42 lines, -0 lines 0 comments Download
A device/usb/mock_usb_device_handle.h View 1 chunk +75 lines, -0 lines 0 comments Download
A device/usb/mock_usb_device_handle.cc View 1 chunk +21 lines, -0 lines 0 comments Download
A device/usb/mock_usb_service.h View 1 chunk +32 lines, -0 lines 0 comments Download
A device/usb/mock_usb_service.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M device/usb/usb.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
M device/usb/usb_device_filter_unittest.cc View 3 chunks +2 lines, -21 lines 0 comments Download
M extensions/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 5 chunks +16 lines, -125 lines 0 comments Download
M extensions/extensions_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Reilly Grant (use Gerrit)
Please review this pretty boring change.
5 years, 7 months ago (2015-05-14 00:00:33 UTC) #2
Reilly Grant (use Gerrit)
Adding Paweł for //chrome/test/BUILD.gn.
5 years, 7 months ago (2015-05-14 00:45:06 UTC) #4
Paweł Hajdan Jr.
LGTM
5 years, 7 months ago (2015-05-14 10:06:40 UTC) #5
Ken Rockot(use gerrit already)
lgtm
5 years, 7 months ago (2015-05-14 14:52:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144493003/60001
5 years, 7 months ago (2015-05-14 15:03:25 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-14 16:06:23 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 16:07:19 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cf9be26f35fa706d770ae59dd6d185aed84edc17
Cr-Commit-Position: refs/heads/master@{#329856}

Powered by Google App Engine
This is Rietveld 408576698