Issue 1144443005: Revert of Tests that the title only ever gets replaced for the current page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1144443005: Revert of Tests that the title only ever gets replaced for the current page. (Closed)

Created:
5 years, 7 months ago by Avi (use Gerrit)

Modified:
5 years, 7 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Tests that the title only ever gets replaced for the current page. (patchset #2 id:20001 of https://codereview.chromium.org/1137773003/) Reason for revert: We're seeing crashes; this looks to be the wrong approach. Original issue's description: > Tests that the title only ever gets replaced for the current page. > > BUG=369661 > TEST=All tests remain green. > > Committed: https://crrev.com/e5fab09f6e313f78d4113e4d4fe0ce3b38ce0ca5 > Cr-Commit-Position: refs/heads/master@{#329414} TBR=creis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369661 Committed: https://crrev.com/456ef962da09318e1e3b637d174c836583b7ac32 Cr-Commit-Position: refs/heads/master@{#329686}

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

Avi (use Gerrit)

Created Revert of Tests that the title only ever gets replaced for the current page.

5 years, 7 months ago (2015-05-13 18:49:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144443005/1

5 years, 7 months ago (2015-05-13 18:50:14 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-13 18:52:45 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/456ef962da09318e1e3b637d174c836583b7ac32
Cr-Commit-Position: refs/heads/master@{#329686}