Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1144433003: Add entries for common FSP providers so we get real names in Analytics places. (Closed)

Created:
5 years, 7 months ago by Steve McKay
Modified:
5 years, 7 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, mtomasz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add entries for common FSP providers so we get real names in Analytics places. TEST=manual Committed: https://crrev.com/118856988dba956fda8dc30e4fdeb3f18baa5261 Cr-Commit-Position: refs/heads/master@{#330016}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Respond to review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M ui/file_manager/file_manager/common/js/metrics_events.js View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Steve McKay
5 years, 7 months ago (2015-05-13 20:55:20 UTC) #2
Steve McKay
NOTE: (YT) == Yoichiro Tanaka (FB) == François Beaufort I thought it would be good ...
5 years, 7 months ago (2015-05-13 20:56:57 UTC) #3
Steve McKay
Oh. And lastly, I based this on the current reporting from analytics: http://go/filesapp-unknown-providers Once we ...
5 years, 7 months ago (2015-05-13 20:59:34 UTC) #4
fukino
lgtm with optional nits. https://codereview.chromium.org/1144433003/diff/1/ui/file_manager/file_manager/common/js/metrics_events.js File ui/file_manager/file_manager/common/js/metrics_events.js (right): https://codereview.chromium.org/1144433003/diff/1/ui/file_manager/file_manager/common/js/metrics_events.js#newcode36 ui/file_manager/file_manager/common/js/metrics_events.js:36: optional nit: We usually use ...
5 years, 7 months ago (2015-05-13 23:12:00 UTC) #5
Steve McKay
Respond to review comments.
5 years, 7 months ago (2015-05-15 01:03:20 UTC) #6
Steve McKay
Dones. Thanks! https://codereview.chromium.org/1144433003/diff/1/ui/file_manager/file_manager/common/js/metrics_events.js File ui/file_manager/file_manager/common/js/metrics_events.js (right): https://codereview.chromium.org/1144433003/diff/1/ui/file_manager/file_manager/common/js/metrics_events.js#newcode36 ui/file_manager/file_manager/common/js/metrics_events.js:36: On 2015/05/13 23:12:00, fukino wrote: > optional ...
5 years, 7 months ago (2015-05-15 01:04:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144433003/20001
5 years, 7 months ago (2015-05-15 01:05:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 01:40:06 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 01:42:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/118856988dba956fda8dc30e4fdeb3f18baa5261
Cr-Commit-Position: refs/heads/master@{#330016}

Powered by Google App Engine
This is Rietveld 408576698