Actually perform a block layout

Actually perform a block layout

This CL teaches simple_render_tree how to do a block layout using layout2.dart.

R=eseidel@chromium.org, ianh@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/d6109ce1ae3a7b73a0e8b6ab0b9d37d05205766d

[abarth-chromium, 2015-05-21 02:43:59]

https://codereview.chromium.org/1144423002/diff/1/sky/sdk/lib/framework/layou...
File sky/sdk/lib/framework/layout2.dart (right):

https://codereview.chromium.org/1144423002/diff/1/sky/sdk/lib/framework/layou...
sky/sdk/lib/framework/layout2.dart:406: BoxConstraints constraints, {double
width, double height}) {
width and height should have default values of 0.0

[eseidel, 2015-05-21 18:08:13]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2015-05-21 18:08:14]

lgtm

https://codereview.chromium.org/1144423002/diff/40001/sky/examples/raw/simple...
File sky/examples/raw/simple_render_tree.dart (right):

https://codereview.chromium.org/1144423002/diff/40001/sky/examples/raw/simple...
sky/examples/raw/simple_render_tree.dart:9: class SimpleBlock extends
RenderDecoratedBox {
Simple isnt' a very good name.  SolidColorBlock?  ColoredBlock?

[abarth-chromium, 2015-05-21 18:15:54]

Committed patchset #3 (id:40001) manually as
d6109ce1ae3a7b73a0e8b6ab0b9d37d05205766d (presubmit successful).

[Hixie, 2015-05-21 19:45:04]

https://codereview.chromium.org/1144423002/diff/40001/sky/examples/raw/simple...
File sky/examples/raw/simple_render_tree.dart (right):

https://codereview.chromium.org/1144423002/diff/40001/sky/examples/raw/simple...
sky/examples/raw/simple_render_tree.dart:9: class SimpleBlock extends
RenderDecoratedBox {
On 2015/05/21 at 18:08:14, eseidel wrote:
> Simple isnt' a very good name.  SolidColorBlock?  ColoredBlock?

TwoHundredPixelHighBlock? :-)

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
File sky/sdk/lib/framework/layout2.dart (left):

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
sky/sdk/lib/framework/layout2.dart:232: ancestor.paintFrame();
This is the code I was talking about earlier.

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
File sky/sdk/lib/framework/layout2.dart (right):

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
sky/sdk/lib/framework/layout2.dart:441: setWidth(constraints, 0.0);
how about:

   width = constraints.constrainWidth(0.0);

...? (and ditto height)

(and remove setWidth/setHeight, since people will think those are an API they
can use from outside)

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
sky/sdk/lib/framework/layout2.dart:447: double height;
I wish we could make these protected and only public expose the getters, but
Dart doesn't have protected.

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
sky/sdk/lib/framework/layout2.dart:463: BoxDecoration({
make this a const constructor.

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
sky/sdk/lib/framework/layout2.dart:615: // TODO(abarth): Shouldn't this have a
value: maxWidth?
good question.

if it does, we should assert that the maxWidth isn't double.INFINITY,
probably...

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
sky/sdk/lib/framework/layout2.dart:627: 
Why the blank line?

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
sky/sdk/lib/framework/layout2.dart:643: width = clamp(min: constraints.minWidth,
max: constraints.maxWidth);
should be consistent with the intrinsic dimensions logic, whatever that is.

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
sky/sdk/lib/framework/layout2.dart:663: child.parentData.x = 0.0; //
TODO(abarth): Shouldn't this be _padding.left?
Yes.

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
sky/sdk/lib/framework/layout2.dart:730: setWidth(constraints, 0.0);
change as discussed above.

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
sky/sdk/lib/framework/layout2.dart:740: toolbar.layout(new
BoxConstraints(minWidth: width, maxWidth: width, minHeight: kToolbarHeight,
maxHeight: kToolbarHeight));
Make a BoxConstraints constructor that takes just a width/height and sets the
min/max accordingly.

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
sky/sdk/lib/framework/layout2.dart:747: statusbar.layout(new
BoxConstraints(minWidth: width, maxWidth: width, minHeight: kStatusbarHeight,
maxHeight: kStatusbarHeight));
ditto

https://codereview.chromium.org/1144423002/diff/40001/sky/sdk/lib/framework/l...
sky/sdk/lib/framework/layout2.dart:753: body.layout(new BoxConstraints(minWidth:
width, maxWidth: width, minHeight: bodyHeight, maxHeight: bodyHeight));
ditto