Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1144413003: Fix ios build (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, stuartmorgan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, --1 lines) Patch
M mojo/mojo_services.gyp View 1 chunk +5 lines, -0 lines 2 comments Download
A + mojo/services/network/xcode_hack.c View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/574ab3817e7220ba7a60c3f44f504c92b6f92710 Cr-Commit-Position: refs/heads/master@{#330903}
5 years, 7 months ago (2015-05-21 05:06:23 UTC) #3
jam
Committed patchset #1 (id:20001) manually as 574ab3817e7220ba7a60c3f44f504c92b6f92710 (presubmit successful).
5 years, 7 months ago (2015-05-21 05:06:39 UTC) #4
stuartmorgan
https://codereview.chromium.org/1144413003/diff/20001/mojo/mojo_services.gyp File mojo/mojo_services.gyp (right): https://codereview.chromium.org/1144413003/diff/20001/mojo/mojo_services.gyp#newcode9 mojo/mojo_services.gyp:9: 'type': 'static_library', I'd recommend instead just making the type ...
5 years, 7 months ago (2015-05-21 13:15:33 UTC) #5
jam
5 years, 7 months ago (2015-05-21 15:27:24 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1144413003/diff/20001/mojo/mojo_services.gyp
File mojo/mojo_services.gyp (right):

https://codereview.chromium.org/1144413003/diff/20001/mojo/mojo_services.gyp#...
mojo/mojo_services.gyp:9: 'type': 'static_library',
On 2015/05/21 13:15:33, stuartmorgan wrote:
> I'd recommend instead just making the type here 'none'. If it has no sources
on
> any platform, then it's really not a static library.

Thanks, I'll try that and talk to Ken as well. I'm not sure why the other
targets that add mojoms have static, or some have none and then have another
static target that has no source files but depends on it.

Powered by Google App Engine
This is Rietveld 408576698