Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ash/drag_drop/drag_drop_controller.cc

Issue 11444013: Get drag and drop working for win aura. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Fix bookmarks interactive tests since now that DRWHW::GetLocationOnNativeScreen is fixed ui_control… Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/ash.gyp ('k') | ash/drag_drop/drag_drop_controller_unittest.cc » ('j') | ui/views/widget/desktop_aura/desktop_drop_target_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/drag_drop/drag_drop_controller.cc
===================================================================
--- ash/drag_drop/drag_drop_controller.cc (revision 171535)
+++ ash/drag_drop/drag_drop_controller.cc (working copy)
@@ -106,6 +106,11 @@
if (IsDragDropInProgress())
return 0;
+#if defined(OS_WIN)
+ NOTIMPLEMENTED();
+ return 0;
+#else
+ // TODO!
Ben Goodger (Google) 2012/12/07 22:00:26 let's make this TODO(win_ash) or TODO(cpu)
jam 2012/12/07 22:07:29 Done. Also added comment about two possible approa
const ui::OSExchangeDataProviderAura& provider =
static_cast<const ui::OSExchangeDataProviderAura&>(data.provider());
// We do not support touch drag/drop without a drag image.
@@ -180,6 +185,7 @@
drag_source_window_->RemoveObserver(this);
drag_source_window_ = NULL;
}
+#endif
return drag_operation_;
}
« no previous file with comments | « ash/ash.gyp ('k') | ash/drag_drop/drag_drop_controller_unittest.cc » ('j') | ui/views/widget/desktop_aura/desktop_drop_target_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698