[DevTools] Load DevTools frontend without iframe (chromium part).

[DevTools] Load DevTools frontend without iframe (chromium part).

BUG=none

Committed: https://crrev.com/5a7ec444c8a02fb7c486451c397283e42268ae96
Cr-Commit-Position: refs/heads/master@{#332419}

[dgozman, 2015-06-01 15:34:44]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2015-06-01 15:34:45]

Take a look please.

[pfeldman, 2015-06-01 15:47:51]

lgtm

https://codereview.chromium.org/1144393004/diff/1/content/browser/devtools/de...
File content/browser/devtools/devtools_frontend_host_impl.cc (right):

https://codereview.chromium.org/1144393004/diff/1/content/browser/devtools/de...
content/browser/devtools/devtools_frontend_host_impl.cc:18: const char
kInjectedDevToolsJS[] = "devtools.js";
compatibility_script

https://codereview.chromium.org/1144393004/diff/1/content/common/devtools_mes...
File content/common/devtools_messages.h (right):

https://codereview.chromium.org/1144393004/diff/1/content/common/devtools_mes...
content/common/devtools_messages.h:115: std::string /* injected script */)
compatibility_script

[dgozman, 2015-06-02 10:51:56]

dgozman@chromium.org changed reviewers:
+ tsepez@chromium.org

[dgozman, 2015-06-02 10:51:56]

Tom, could you please take a look at devtools_messages.h?

We used to evaluate compatibility script in a separate frame, but I'm getting
rid of it for simplicity and performance.

Thanks,
Dmitry

https://codereview.chromium.org/1144393004/diff/1/content/browser/devtools/de...
File content/browser/devtools/devtools_frontend_host_impl.cc (right):

https://codereview.chromium.org/1144393004/diff/1/content/browser/devtools/de...
content/browser/devtools/devtools_frontend_host_impl.cc:18: const char
kInjectedDevToolsJS[] = "devtools.js";
On 2015/06/01 15:47:51, pfeldman wrote:
> compatibility_script

Done.

https://codereview.chromium.org/1144393004/diff/1/content/common/devtools_mes...
File content/common/devtools_messages.h (right):

https://codereview.chromium.org/1144393004/diff/1/content/common/devtools_mes...
content/common/devtools_messages.h:115: std::string /* injected script */)
On 2015/06/01 15:47:51, pfeldman wrote:
> compatibility_script

Done.

[Tom Sepez, 2015-06-02 15:43:06]

Messages LGTM assuming that the browser process has complete control over the
script being sent (and it's not influenced by something previously sent by a
less trusted process like another renderer).

[dgozman, 2015-06-02 15:46:17]

On 2015/06/02 15:43:06, Tom Sepez wrote:
> Messages LGTM assuming that the browser process has complete control over the
> script being sent (and it's not influenced by something previously sent by a
> less trusted process like another renderer).

Script is taken directly from resource bundle.
Thank you!

[dgozman, 2015-06-02 15:46:20]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2015-06-02 15:46:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1144393004/#ps20001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2015-06-02 15:47:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144393004/20001

[commit-bot: I haz the power, 2015-06-02 17:27:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-02 17:28:59]

Patchset 2 (id:??) landed as
https://crrev.com/5a7ec444c8a02fb7c486451c397283e42268ae96
Cr-Commit-Position: refs/heads/master@{#332419}