test/cctest/test-heap.cc - Issue 1144393003: Also allocate small typed arrays on heap when initialized from an array-like

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap.cc

Issue 1144393003: Also allocate small typed arrays on heap when initialized from an array-like (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-heap.cc

diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc

index da19f09f7cc22f6202ade9172d4edefeb943975b..79ced70618330252e00f1a2076f6bf6c567ff9ce 100644

--- a/test/cctest/test-heap.cc

+++ b/test/cctest/test-heap.cc

@@ -5441,7 +5441,7 @@ static void TestRightTrimFixedTypedArray(i::ExternalArrayType type,

Heap* heap = isolate->heap();

Handle<FixedTypedArrayBase> array =

- factory->NewFixedTypedArray(initial_length, type);

+ factory->NewFixedTypedArray(initial_length, type, true);

int old_size = array->size();

heap->RightTrimFixedArray<Heap::CONCURRENT_TO_SWEEPER>(*array,

elements_to_trim);

« no previous file with comments | « src/typedarray.js ('k') | test/cctest/test-typedarrays.cc » ('j') | no next file with comments »