Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1144393003: Also allocate small typed arrays on heap when initialized from an array-like (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Also allocate small typed arrays on heap when initialized from an array-like This means something like new Float32Array([23, 42]) will be allocated on heap. BUG=v8:3996 R=bmeurer@chromium.org,mstarzinger@chromium.org LOG=y Committed: https://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579 Cr-Commit-Position: refs/heads/master@{#28780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -37 lines) Patch
M src/factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/factory.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/hydrogen.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 6 chunks +14 lines, -7 lines 0 comments Download
M src/layout-descriptor-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-typedarray.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/typedarray.js View 3 chunks +12 lines, -4 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-typedarrays.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
jochen (gone - plz use gerrit)
5 years, 6 months ago (2015-06-01 15:13:53 UTC) #1
jochen (gone - plz use gerrit)
wdyt? the impact on the code is minimal...
5 years, 6 months ago (2015-06-01 15:14:27 UTC) #2
Benedikt Meurer
On 2015/06/01 15:14:27, jochen wrote: > wdyt? > > the impact on the code is ...
5 years, 6 months ago (2015-06-02 04:43:02 UTC) #3
jochen (gone - plz use gerrit)
On 2015/06/02 at 04:43:02, bmeurer wrote: > On 2015/06/01 15:14:27, jochen wrote: > > wdyt? ...
5 years, 6 months ago (2015-06-02 07:36:40 UTC) #4
Michael Starzinger
LGTM.
5 years, 6 months ago (2015-06-02 12:02:49 UTC) #5
jochen (gone - plz use gerrit)
I'll land this tomorrow.
5 years, 6 months ago (2015-06-02 14:01:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144393003/1
5 years, 6 months ago (2015-06-03 07:17:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 07:41:33 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 07:41:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579
Cr-Commit-Position: refs/heads/master@{#28780}

Powered by Google App Engine
This is Rietveld 408576698