Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1144383008: Remove HistoryItem::m_frameSequenceNumber, it is unused (Closed)

Created:
5 years, 6 months ago by Nate Chapin
Modified:
5 years, 6 months ago
Reviewers:
dcheng
CC:
blink-reviews, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove HistoryItem::m_frameSequenceNumber, it is unused BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M Source/core/loader/HistoryItem.h View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/core/loader/HistoryItem.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebHistoryItem.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M public/web/WebHistoryItem.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nate Chapin
This is unused after https://codereview.chromium.org/1138543002/
5 years, 6 months ago (2015-06-02 22:01:18 UTC) #2
dcheng
lgtm!
5 years, 6 months ago (2015-06-02 22:03:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144383008/1
5 years, 6 months ago (2015-06-02 22:04:48 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 23:15:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196354

Powered by Google App Engine
This is Rietveld 408576698