Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1144383002: A couple of cleanups for gyp_chromium (Closed)

Created:
5 years, 7 months ago by Sam Clegg
Modified:
5 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A couple of cleanups for gyp_chromium Use subprocess.call() rather than Popen + communicate. The shell argument to Popen defaults to False so was redundant. Use any() rather than explicit loop. Committed: https://crrev.com/bf94627aa3bb2e6d4577dbf27288f15d90dcf68c Cr-Commit-Position: refs/heads/master@{#330854}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M build/gyp_chromium View 1 chunk +3 lines, -10 lines 3 comments Download

Messages

Total messages: 9 (2 generated)
Sam Clegg
5 years, 7 months ago (2015-05-20 22:27:37 UTC) #2
scottmg
lgtm https://codereview.chromium.org/1144383002/diff/1/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/1144383002/diff/1/build/gyp_chromium#newcode221 build/gyp_chromium:221: # TODO(bradnelson): take this out once this issue ...
5 years, 7 months ago (2015-05-20 22:30:56 UTC) #3
Sam Clegg
https://codereview.chromium.org/1144383002/diff/1/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/1144383002/diff/1/build/gyp_chromium#newcode221 build/gyp_chromium:221: # TODO(bradnelson): take this out once this issue is ...
5 years, 7 months ago (2015-05-20 22:38:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144383002/1
5 years, 7 months ago (2015-05-20 22:40:34 UTC) #6
scottmg
https://codereview.chromium.org/1144383002/diff/1/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/1144383002/diff/1/build/gyp_chromium#newcode221 build/gyp_chromium:221: # TODO(bradnelson): take this out once this issue is ...
5 years, 7 months ago (2015-05-20 22:40:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 00:02:20 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 00:03:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf94627aa3bb2e6d4577dbf27288f15d90dcf68c
Cr-Commit-Position: refs/heads/master@{#330854}

Powered by Google App Engine
This is Rietveld 408576698