Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1144363003: Progress dots are now hidden on enrollment screen. (Closed)

Created:
5 years, 7 months ago by dzhioev (left Google)
Modified:
5 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Progress dots are now hidden on enrollment screen. BUG=482364 TEST=manually Committed: https://crrev.com/480e30a0792eb967da878dd15cd9ba395345fecb Cr-Commit-Position: refs/heads/master@{#331027}

Patch Set 1 #

Patch Set 2 : Removed dot for "device-disabled" screen. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/login/screen_container.css View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dzhioev (left Google)
Hi Nikita, please review.
5 years, 7 months ago (2015-05-21 00:55:34 UTC) #2
Nikita (slow)
While you're at it please check why there're more progress dots then needed - like ...
5 years, 7 months ago (2015-05-21 11:35:47 UTC) #3
Nikita (slow)
lgtm
5 years, 7 months ago (2015-05-21 11:35:59 UTC) #4
dzhioev (left Google)
On 2015/05/21 11:35:47, Nikita wrote: > While you're at it please check why there're more ...
5 years, 7 months ago (2015-05-21 22:16:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144363003/20001
5 years, 7 months ago (2015-05-21 22:18:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 23:35:33 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 23:36:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/480e30a0792eb967da878dd15cd9ba395345fecb
Cr-Commit-Position: refs/heads/master@{#331027}

Powered by Google App Engine
This is Rietveld 408576698