Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(46)

Issue 1144353005: [SVG] Lower stroke hit testing resolution. (Closed)

Created:
4 years, 11 months ago by f(malita)
Modified:
4 years, 11 months ago
Reviewers:
fs, caryclark
CC:
blink-reviews, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, Stephen Chennney, rwlbuis, reed1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[SVG] Lower stroke hit testing resolution. Skia uses a default stroke path resolution of 1/4. This is overkill for hit-testing purposes, and can be lowered without affecting the result accuracy significantly. TEST=svg/hittest/* BUG=491239 R=caryclark@google.com,fs@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196264

Patch Set 1 #

Patch Set 2 : let's try a .26 scale #

Patch Set 3 : back to 3.0 + ctm comment #

Patch Set 4 : expectations #

Patch Set 5 : +2 mac expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M Source/platform/graphics/Path.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/Path.cpp View 1 2 2 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
f(malita)
A scale of 0.3 shows a 16-18% improvement for blink_perf.svg/SVGHitTesting without introducing any layout test ...
4 years, 11 months ago (2015-05-29 21:07:18 UTC) #1
caryclark
lgtm
4 years, 11 months ago (2015-05-29 21:11:15 UTC) #2
f(malita)
On 2015/05/29 21:07:18, f(malita) wrote: > A scale of 0.3 shows a 16-18% improvement for ...
4 years, 11 months ago (2015-05-30 16:37:15 UTC) #3
fs
On 2015/05/30 16:37:15, f(malita) wrote: > On 2015/05/29 21:07:18, f(malita) wrote: > > A scale ...
4 years, 11 months ago (2015-06-01 07:58:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144353005/80001
4 years, 11 months ago (2015-06-01 12:55:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/34202)
4 years, 11 months ago (2015-06-01 13:01:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144353005/80001
4 years, 11 months ago (2015-06-01 19:49:20 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64248)
4 years, 11 months ago (2015-06-01 23:35:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144353005/80001
4 years, 11 months ago (2015-06-01 23:58:38 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 00:56:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196264

Powered by Google App Engine
This is Rietveld 408576698