Do not attempt to open a channel to a plugin in Plugin Data Remover if there are no plugins availab…

content/browser/plugin_data_remover_impl.cc

Index: content/browser/plugin_data_remover_impl.cc
diff --git a/content/browser/plugin_data_remover_impl.cc b/content/browser/plugin_data_remover_impl.cc
index 43930ba1de7eb359783b1f0cafcdd7e72dd6bb75..bc87d8e03915abe668a44c0770ed6154b3e59c72 100644
--- a/content/browser/plugin_data_remover_impl.cc
+++ b/content/browser/plugin_data_remover_impl.cc
@@ -91,9 +91,13 @@ class PluginDataRemoverImpl::Context
     std::vector<WebPluginInfo> plugins;
     plugin_service->GetPluginInfoArray(
         GURL(), mime_type, false, &plugins, NULL);
-    base::FilePath plugin_path;
-    if (!plugins.empty())  // May be empty for some tests.
-      plugin_path = plugins[0].path;
+
+    if (plugins.empty()) {
+      // May be empty for some tests and on the CrOS login OOBE screen.
+      OnTimeout();

[Bernhard Bauer, 2015/05/20 21:48:34]

We should probably call this method OnError() now.

[Will Harris, 2015/05/20 21:52:12]

I tried calling OnError() first, but it prints a scary error "Couldn't open
plugin channel" which isn't really an error, since having no plugins is not an
error... so I went with OnTimeout() without setting is_removing_ which prints
nothing.  WDYT?

[Bernhard Bauer, 2015/05/20 21:55:03]

Oh, durr. We really only need SignalDone(), so I guess that's what we should
call.

[Will Harris, 2015/05/20 22:02:59]

yes. good plan.

+      return;
+    }
+    base::FilePath plugin_path = plugins[0].path;
 
     DCHECK_CURRENTLY_ON(BrowserThread::IO);
     remove_start_time_ = base::Time::Now();