Do not attempt to open a channel to a plugin in Plugin Data Remover if there are no plugins availab…

Do not attempt to open a channel to a plugin in Plugin Data Remover if there are no plugins available.

BUG=485886
Committed: https://crrev.com/2327c7044eeabc2e70700ff7f752e4b2e2978657
Cr-Commit-Position: refs/heads/master@{#331168}

[Will Harris, 2015-05-20 21:46:02]

wfh@chromium.org changed reviewers:
+ bauerb@chromium.org

[Will Harris, 2015-05-20 21:46:16]

PTAL - this fixes the issue with the CrOS OOBE

[Bernhard Bauer, 2015-05-20 21:48:34]

Thank you! I've been meaning to do this for a while (well, I've been meaning to
do this at some point, then forgot about it...)

https://codereview.chromium.org/1144353003/diff/1/content/browser/plugin_data...
File content/browser/plugin_data_remover_impl.cc (right):

https://codereview.chromium.org/1144353003/diff/1/content/browser/plugin_data...
content/browser/plugin_data_remover_impl.cc:97: OnTimeout();
We should probably call this method OnError() now.

[Bernhard Bauer, 2015-05-20 21:48:40]

Oh, and LGTM

[Will Harris, 2015-05-20 21:52:12]

https://codereview.chromium.org/1144353003/diff/1/content/browser/plugin_data...
File content/browser/plugin_data_remover_impl.cc (right):

https://codereview.chromium.org/1144353003/diff/1/content/browser/plugin_data...
content/browser/plugin_data_remover_impl.cc:97: OnTimeout();
On 2015/05/20 21:48:34, Bernhard Bauer wrote:
> We should probably call this method OnError() now.

I tried calling OnError() first, but it prints a scary error "Couldn't open
plugin channel" which isn't really an error, since having no plugins is not an
error... so I went with OnTimeout() without setting is_removing_ which prints
nothing.  WDYT?

[Bernhard Bauer, 2015-05-20 21:55:03]

https://codereview.chromium.org/1144353003/diff/1/content/browser/plugin_data...
File content/browser/plugin_data_remover_impl.cc (right):

https://codereview.chromium.org/1144353003/diff/1/content/browser/plugin_data...
content/browser/plugin_data_remover_impl.cc:97: OnTimeout();
On 2015/05/20 21:52:12, Will Harris wrote:
> On 2015/05/20 21:48:34, Bernhard Bauer wrote:
> > We should probably call this method OnError() now.
> 
> I tried calling OnError() first, but it prints a scary error "Couldn't open
> plugin channel" which isn't really an error, since having no plugins is not an
> error... so I went with OnTimeout() without setting is_removing_ which prints
> nothing.  WDYT?

Oh, durr. We really only need SignalDone(), so I guess that's what we should
call.

[Will Harris, 2015-05-20 22:03:00]

most of my time was spent complaining to my officemates about having to use
gdb... :)

https://codereview.chromium.org/1144353003/diff/1/content/browser/plugin_data...
File content/browser/plugin_data_remover_impl.cc (right):

https://codereview.chromium.org/1144353003/diff/1/content/browser/plugin_data...
content/browser/plugin_data_remover_impl.cc:97: OnTimeout();
On 2015/05/20 21:55:03, Bernhard Bauer wrote:
> On 2015/05/20 21:52:12, Will Harris wrote:
> > On 2015/05/20 21:48:34, Bernhard Bauer wrote:
> > > We should probably call this method OnError() now.
> > 
> > I tried calling OnError() first, but it prints a scary error "Couldn't open
> > plugin channel" which isn't really an error, since having no plugins is not
an
> > error... so I went with OnTimeout() without setting is_removing_ which
prints
> > nothing.  WDYT?
> 
> Oh, durr. We really only need SignalDone(), so I guess that's what we should
> call.

yes. good plan.

[Will Harris, 2015-05-20 22:03:43]

wfh@chromium.org changed reviewers:
+ creis@chromium.org

[Will Harris, 2015-05-20 22:03:44]

looking for an OWNER el gee tee em please

[Charlie Reis, 2015-05-20 23:53:18]

LGTM!

[Will Harris, 2015-05-21 04:03:59]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2015-05-21 04:03:59]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1144353003/#ps20001
(title: "code review comments")

[commit-bot: I haz the power, 2015-05-21 04:06:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144353003/20001

[commit-bot: I haz the power, 2015-05-21 05:06:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-21 05:06:17]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Will Harris, 2015-05-22 20:45:46]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2015-05-22 20:45:47]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
creis@chromium.org
Link to the patchset: https://codereview.chromium.org/1144353003/#ps60001
(title: "signal done doesn't actually signal it's done if there is nothing to
do.")

[commit-bot: I haz the power, 2015-05-22 20:46:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144353003/60001

[commit-bot: I haz the power, 2015-05-22 21:07:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-22 21:08:14]

Patchset 4 (id:??) landed as
https://crrev.com/2327c7044eeabc2e70700ff7f752e4b2e2978657
Cr-Commit-Position: refs/heads/master@{#331168}