Adding unit tests for BLE connection.

components/proximity_auth/ble/bluetooth_low_energy_connection_unittest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/proximity_auth/ble/bluetooth_low_energy_connection.h"
+
+#include "base/bind.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "components/proximity_auth/ble/bluetooth_low_energy_characteristics_finder.h"
+#include "components/proximity_auth/connection_finder.h"
+#include "components/proximity_auth/remote_device.h"
+#include "components/proximity_auth/wire_message.h"
+#include "device/bluetooth/bluetooth_adapter_factory.h"
+#include "device/bluetooth/bluetooth_gatt_characteristic.h"
+#include "device/bluetooth/bluetooth_uuid.h"
+#include "device/bluetooth/test/mock_bluetooth_adapter.h"
+#include "device/bluetooth/test/mock_bluetooth_device.h"
+#include "device/bluetooth/test/mock_bluetooth_discovery_session.h"
+#include "device/bluetooth/test/mock_bluetooth_gatt_characteristic.h"
+#include "device/bluetooth/test/mock_bluetooth_gatt_connection.h"
+#include "device/bluetooth/test/mock_bluetooth_gatt_notify_session.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::_;
+using testing::AtLeast;
+using testing::NiceMock;
+using testing::Return;
+using testing::StrictMock;
+using testing::SaveArg;
+
+namespace proximity_auth {
+namespace {
+
+const char kDeviceName[] = "Device name";
+const char kBluetoothAddress[] = "11:22:33:44:55:66";
+
+const char kServiceUUID[] = "DEADBEEF-CAFE-FEED-FOOD-D15EA5EBEEEF";
+const char kToPeripheralCharUUID[] = "FBAE09F2-0482-11E5-8418-1697F925EC7B";
+const char kFromPeripheralCharUUID[] = "5539ED10-0483-11E5-8418-1697F925EC7B";
+
+const char kServiceID[] = "service id";
+const char kToPeripheralCharID[] = "to peripheral char id";
+const char kFromPeripheralCharID[] = "from peripheral char id";
+
+const device::BluetoothGattCharacteristic::Properties
+    kCharacteristicProperties =
+        device::BluetoothGattCharacteristic::PROPERTY_BROADCAST |
+        device::BluetoothGattCharacteristic::PROPERTY_READ |
+        device::BluetoothGattCharacteristic::PROPERTY_WRITE_WITHOUT_RESPONSE |
+        device::BluetoothGattCharacteristic::PROPERTY_INDICATE;
+
+const int kMaxNumberOfTries = 3;
+
+class MockBluetoothLowEnergyCharacteristicsFinder
+    : public BluetoothLowEnergyCharacteristicsFinder {
+ public:
+  MockBluetoothLowEnergyCharacteristicsFinder() {}
+  ~MockBluetoothLowEnergyCharacteristicsFinder() override {}
+};
+
+class MockBluetoothLowEnergyConnection : public BluetoothLowEnergyConnection {
+ public:
+  using BluetoothLowEnergyConnection::BluetoothLowEnergyConnection;
+  ~MockBluetoothLowEnergyConnection() override {}
+
+  MOCK_METHOD2(
+      CreateCharacteristicsFinder,
+      BluetoothLowEnergyCharacteristicsFinder*(
+          const BluetoothLowEnergyCharacteristicsFinder::SuccessCallback&
+              success,
+          const BluetoothLowEnergyCharacteristicsFinder::ErrorCallback& error));
+
+  MOCK_METHOD2(OnDidSendMessage,
+               void(const WireMessage& message, bool success));
+

[msarda, 2015/06/05 09:40:19]

// Exposing inherited protected methods for testing.

[sacomoto, 2015/06/05 11:04:04]

Done.

+  using BluetoothLowEnergyConnection::GattCharacteristicValueChanged;
+

[msarda, 2015/06/05 09:40:19]

// Exposing inherited protected fields for testing.

[sacomoto, 2015/06/05 11:04:04]

Done.

+  using BluetoothLowEnergyConnection::status;
+  using BluetoothLowEnergyConnection::SubStatus;
+  using BluetoothLowEnergyConnection::sub_status;
+};
+
+}  // namespace
+
+class ProximityAuthBluetoothLowEnergyConnectionTest : public testing::Test {
+ public:
+  ProximityAuthBluetoothLowEnergyConnectionTest()

[msarda, 2015/06/05 09:40:19]

This may be a personal preference, but I prefer having test SetUp and TearDown
do the setup required for the test. Could you move part of this to a SetUp
function?

[sacomoto, 2015/06/05 11:04:04]

Done.

+      : adapter_(new NiceMock<device::MockBluetoothAdapter>),
+        remote_device_({kDeviceName, kBluetoothAddress}),
+        service_uuid_(device::BluetoothUUID(kServiceUUID)),
+        to_peripheral_char_uuid_(device::BluetoothUUID(kToPeripheralCharUUID)),
+        from_peripheral_char_uuid_(
+            device::BluetoothUUID(kFromPeripheralCharUUID)),
+        gatt_connection_(new NiceMock<device::MockBluetoothGattConnection>(
+            kBluetoothAddress)),
+        gatt_connection_alias_(gatt_connection_.get()),
+        device_(new NiceMock<device::MockBluetoothDevice>(adapter_.get(),
+                                                          0,
+                                                          kDeviceName,
+                                                          kBluetoothAddress,
+                                                          false,
+                                                          false)),
+        service_(new NiceMock<device::MockBluetoothGattService>(device_.get(),
+                                                                kServiceID,
+                                                                service_uuid_,
+                                                                true,
+                                                                false)),
+        to_peripheral_char_(
+            new NiceMock<device::MockBluetoothGattCharacteristic>(
+                service_.get(),
+                kToPeripheralCharID,
+                to_peripheral_char_uuid_,
+                false,
+                kCharacteristicProperties,
+                device::BluetoothGattCharacteristic::PERMISSION_NONE)),
+        from_peripheral_char_(
+            new NiceMock<device::MockBluetoothGattCharacteristic>(
+                service_.get(),
+                kFromPeripheralCharID,
+                from_peripheral_char_uuid_,
+                false,
+                kCharacteristicProperties,
+                device::BluetoothGattCharacteristic::PERMISSION_NONE)),
+        notify_session_alias_(NULL) {
+    device::BluetoothAdapterFactory::SetAdapterForTesting(adapter_);
+
+    ON_CALL(*adapter_, GetDevice(kBluetoothAddress))
+        .WillByDefault(Return(device_.get()));
+    ON_CALL(*device_, GetGattService(kServiceID))
+        .WillByDefault(Return(service_.get()));
+    ON_CALL(*service_, GetCharacteristic(kFromPeripheralCharID))
+        .WillByDefault(Return(from_peripheral_char_.get()));
+    ON_CALL(*service_, GetCharacteristic(kToPeripheralCharID))
+        .WillByDefault(Return(to_peripheral_char_.get()));
+  }
+
+  // Creates a BluetoothLowEnergyConnection and verifies it's in DISCONNECTED
+  // state.
+  scoped_ptr<MockBluetoothLowEnergyConnection> CreateConnection() {
+    EXPECT_CALL(*adapter_, AddObserver(_));
+    EXPECT_CALL(*adapter_, RemoveObserver(_));
+
+    scoped_ptr<MockBluetoothLowEnergyConnection> connection(
+        new MockBluetoothLowEnergyConnection(
+            remote_device_, adapter_, service_uuid_, to_peripheral_char_uuid_,
+            from_peripheral_char_uuid_, gatt_connection_.Pass(),
+            kMaxNumberOfTries));
+
+    EXPECT_EQ(connection->sub_status(),
+              MockBluetoothLowEnergyConnection::SubStatus::DISCONNECTED);
+    EXPECT_EQ(connection->status(), Connection::DISCONNECTED);
+
+    return connection.Pass();
+  }
+
+  // Transitions |connection| from DISCONNECTED to WAITING_CHARACTERISTICS
+  // state, using an existing GATT connection.
+  void ConnectWithExistingGattConnection(
+      MockBluetoothLowEnergyConnection* connection) {
+    EXPECT_CALL(*gatt_connection_alias_, IsConnected()).WillOnce(Return(true));
+    EXPECT_CALL(*connection, CreateCharacteristicsFinder(_, _))
+        .WillOnce(
+            DoAll(SaveArg<0>(&characteristics_finder_success_callback_),
+                  SaveArg<1>(&characteristics_finder_error_callback_),
+                  Return(new MockBluetoothLowEnergyCharacteristicsFinder)));
+
+    connection->Connect();
+
+    EXPECT_EQ(
+        connection->sub_status(),
+        MockBluetoothLowEnergyConnection::SubStatus::WAITING_CHARACTERISTICS);
+    EXPECT_EQ(connection->status(), Connection::IN_PROGRESS);
+  }
+
+  // Transitions |connection| from DISCONNECTED to WAITING_CHARACTERISTICS
+  // state, without an existing GATT connection.
+  void ConnectWithoutExistingGattConnection(
+      MockBluetoothLowEnergyConnection* connection) {
+    // Preparing |connection| for a CreateGattConnection call.
+    EXPECT_CALL(*gatt_connection_alias_, IsConnected()).WillOnce(Return(false));
+    EXPECT_CALL(*device_, CreateGattConnection(_, _))
+        .WillOnce(DoAll(SaveArg<0>(&create_gatt_connection_success_callback_),
+                        SaveArg<1>(&create_gatt_connection_error_callback_)));
+
+    connection->Connect();
+
+    EXPECT_EQ(
+        connection->sub_status(),
+        MockBluetoothLowEnergyConnection::SubStatus::WAITING_GATT_CONNECTION);
+    EXPECT_EQ(connection->status(), Connection::IN_PROGRESS);
+
+    // Preparing |connection| to run |create_gatt_connection_success_callback_|.
+    EXPECT_FALSE(create_gatt_connection_error_callback_.is_null());
+    ASSERT_FALSE(create_gatt_connection_success_callback_.is_null());
+    EXPECT_CALL(*connection, CreateCharacteristicsFinder(_, _))
+        .WillOnce(DoAll(
+            SaveArg<0>(&characteristics_finder_success_callback_),
+            SaveArg<1>(&characteristics_finder_error_callback_),
+            Return(new NiceMock<MockBluetoothLowEnergyCharacteristicsFinder>)));
+
+    create_gatt_connection_success_callback_.Run(make_scoped_ptr(
+        new NiceMock<device::MockBluetoothGattConnection>(kBluetoothAddress)));
+
+    EXPECT_EQ(
+        connection->sub_status(),
+        MockBluetoothLowEnergyConnection::SubStatus::WAITING_CHARACTERISTICS);
+    EXPECT_EQ(connection->status(), Connection::IN_PROGRESS);
+  }
+
+  // Transitions |connection| from WAITING_CHARACTERISTICS to
+  // WAITING_NOTIFY_SESSION state.
+  void CharacteristicsFound(MockBluetoothLowEnergyConnection* connection) {
+    EXPECT_CALL(*from_peripheral_char_, StartNotifySession(_, _))
+        .WillOnce(DoAll(SaveArg<0>(&notify_session_success_callback_),
+                        SaveArg<1>(&notify_session_error_callback_)));
+    EXPECT_FALSE(characteristics_finder_error_callback_.is_null());
+    ASSERT_FALSE(characteristics_finder_success_callback_.is_null());
+
+    characteristics_finder_success_callback_.Run(
+        {service_uuid_, kServiceID},
+        {to_peripheral_char_uuid_, kToPeripheralCharID},
+        {from_peripheral_char_uuid_, kFromPeripheralCharID});
+
+    EXPECT_EQ(
+        connection->sub_status(),
+        MockBluetoothLowEnergyConnection::SubStatus::WAITING_NOTIFY_SESSION);
+    EXPECT_EQ(connection->status(), Connection::IN_PROGRESS);
+  }
+
+  // Transitions |connection| from WAITING_NOTIFY_SESSION to
+  // WAITING_RESPONSE_SIGNAL state.
+  void NotifySessionStarted(MockBluetoothLowEnergyConnection* connection) {
+    EXPECT_CALL(*to_peripheral_char_, WriteRemoteCharacteristic(_, _, _))
+        .WillOnce(
+            DoAll(SaveArg<0>(&last_value_written_on_to_peripheral_char_),
+                  SaveArg<1>(&write_remote_characteristic_success_callback_),
+                  SaveArg<2>(&write_remote_characteristic_error_callback_)));
+    EXPECT_FALSE(notify_session_error_callback_.is_null());
+    ASSERT_FALSE(notify_session_success_callback_.is_null());
+
+    // Store an alias for the notify session passed |connection|.
+    scoped_ptr<device::MockBluetoothGattNotifySession> notify_session(
+        new NiceMock<device::MockBluetoothGattNotifySession>(
+            kToPeripheralCharID));
+    notify_session_alias_ = notify_session.get();
+    notify_session_success_callback_.Run(notify_session.Pass());
+
+    EXPECT_EQ(
+        connection->sub_status(),
+        MockBluetoothLowEnergyConnection::SubStatus::WAITING_RESPONSE_SIGNAL);
+    EXPECT_EQ(connection->status(), Connection::IN_PROGRESS);
+  }
+
+  // Transitions |connection| from WAITING_RESPONSE_SIGNAL to CONNECTED state.
+  void ResponseSignalReceived(MockBluetoothLowEnergyConnection* connection) {
+    // Written value contains only the
+    // BluetoothLowEneryConnection::ControlSignal::kSendSignal.
+    const std::vector<uint8> kSendSignal = {0, 0, 0, 0};
+    EXPECT_EQ(last_value_written_on_to_peripheral_char_, kSendSignal);
+
+    EXPECT_CALL(*connection, OnDidSendMessage(_, _)).Times(0);
+    EXPECT_FALSE(write_remote_characteristic_error_callback_.is_null());
+    ASSERT_FALSE(write_remote_characteristic_success_callback_.is_null());
+    write_remote_characteristic_success_callback_.Run();
+
+    // Received the
+    // BluetoothLowEneryConnection::ControlSignal::kInvitationResponseSignal.
+    const std::vector<uint8> kInvitationResponseSignal = {1, 0, 0, 0};
+    connection->GattCharacteristicValueChanged(
+        adapter_.get(), from_peripheral_char_.get(), kInvitationResponseSignal);
+
+    EXPECT_EQ(connection->sub_status(),
+              MockBluetoothLowEnergyConnection::SubStatus::CONNECTED);
+    EXPECT_EQ(connection->status(), Connection::CONNECTED);
+  }
+
+  // Transitions |connection| to a DISCONNECTED state regardless of its initial
+  // state.
+  void Disconnect(MockBluetoothLowEnergyConnection* connection) {
+    // A notify session was previously set.
+    if (notify_session_alias_)
+      EXPECT_CALL(*notify_session_alias_, Stop(_));
+
+    connection->Disconnect();
+
+    EXPECT_EQ(connection->sub_status(),
+              MockBluetoothLowEnergyConnection::SubStatus::DISCONNECTED);
+    EXPECT_EQ(connection->status(), Connection::DISCONNECTED);
+  }
+
+ protected:
+  scoped_refptr<device::MockBluetoothAdapter> adapter_;
+  RemoteDevice remote_device_;
+  device::BluetoothUUID service_uuid_;
+  device::BluetoothUUID to_peripheral_char_uuid_;
+  device::BluetoothUUID from_peripheral_char_uuid_;
+  scoped_ptr<device::MockBluetoothGattConnection> gatt_connection_;
+  device::MockBluetoothGattConnection* gatt_connection_alias_;

[msarda, 2015/06/05 09:40:19]

I think this is useless (only used twice). Please remove it and replace its
usage with gatt_connection_.get().

[sacomoto, 2015/06/05 11:04:04]

We cannot remove it. We pass the ownership of |gatt_connection_| when creating
the BluetoothLowEnergyConnection object in CreateConnection(). But then we need
it again in ConnectWithoutExistingGattConnection() and |gatt_connection_| is
already NULL.

+  scoped_ptr<device::MockBluetoothDevice> device_;
+  scoped_ptr<device::MockBluetoothGattService> service_;
+  scoped_ptr<device::MockBluetoothGattCharacteristic> to_peripheral_char_;
+  scoped_ptr<device::MockBluetoothGattCharacteristic> from_peripheral_char_;
+  std::vector<uint8> last_value_written_on_to_peripheral_char_;
+  device::MockBluetoothGattNotifySession* notify_session_alias_;
+
+  // Callbacks
+  device::BluetoothDevice::GattConnectionCallback
+      create_gatt_connection_success_callback_;
+  device::BluetoothDevice::ConnectErrorCallback
+      create_gatt_connection_error_callback_;
+
+  BluetoothLowEnergyCharacteristicsFinder::SuccessCallback
+      characteristics_finder_success_callback_;
+  BluetoothLowEnergyCharacteristicsFinder::ErrorCallback
+      characteristics_finder_error_callback_;
+
+  device::BluetoothGattCharacteristic::NotifySessionCallback
+      notify_session_success_callback_;
+  device::BluetoothGattCharacteristic::ErrorCallback
+      notify_session_error_callback_;
+
+  base::Closure write_remote_characteristic_success_callback_;
+  device::BluetoothGattCharacteristic::ErrorCallback
+      write_remote_characteristic_error_callback_;
+};
+
+TEST_F(ProximityAuthBluetoothLowEnergyConnectionTest,
+       CreateAndDestroyWithouthConnectCallDoesntCrash) {
+  BluetoothLowEnergyConnection connection(
+      remote_device_, adapter_, service_uuid_, to_peripheral_char_uuid_,
+      from_peripheral_char_uuid_, gatt_connection_.Pass(), kMaxNumberOfTries);
+}
+
+TEST_F(ProximityAuthBluetoothLowEnergyConnectionTest,
+       Disconect_WithoutConnectDoesntCrash) {
+  scoped_ptr<MockBluetoothLowEnergyConnection> connection(CreateConnection());
+  Disconnect(connection.get());
+}
+
+TEST_F(ProximityAuthBluetoothLowEnergyConnectionTest,
+       Connect_Success_WithGattConnection) {
+  scoped_ptr<MockBluetoothLowEnergyConnection> connection(CreateConnection());
+  ConnectWithExistingGattConnection(connection.get());
+  CharacteristicsFound(connection.get());
+  NotifySessionStarted(connection.get());
+  ResponseSignalReceived(connection.get());
+}
+
+TEST_F(ProximityAuthBluetoothLowEnergyConnectionTest,
+       Connect_Success_WithoutGattConnection) {
+  scoped_ptr<MockBluetoothLowEnergyConnection> connection(CreateConnection());
+  ConnectWithoutExistingGattConnection(connection.get());
+  CharacteristicsFound(connection.get());
+  NotifySessionStarted(connection.get());
+  ResponseSignalReceived(connection.get());
+}
+
+TEST_F(ProximityAuthBluetoothLowEnergyConnectionTest,
+       Connect_Success_Disconnect) {
+  scoped_ptr<MockBluetoothLowEnergyConnection> connection(CreateConnection());
+  ConnectWithExistingGattConnection(connection.get());
+  CharacteristicsFound(connection.get());
+  NotifySessionStarted(connection.get());
+  ResponseSignalReceived(connection.get());
+  Disconnect(connection.get());
+}
+
+TEST_F(
+    ProximityAuthBluetoothLowEnergyConnectionTest,
+    Connect_Incomplete_Disconnect_FromWaitingCharacteristicsStateWithoutExistingGattConnection) {
+  scoped_ptr<MockBluetoothLowEnergyConnection> connection(CreateConnection());
+  ConnectWithoutExistingGattConnection(connection.get());
+  Disconnect(connection.get());
+}
+
+TEST_F(ProximityAuthBluetoothLowEnergyConnectionTest,
+       Connect_Incomplete_Disconnect_FromWaitingCharacteristicsState) {
+  scoped_ptr<MockBluetoothLowEnergyConnection> connection(CreateConnection());
+  ConnectWithExistingGattConnection(connection.get());
+  Disconnect(connection.get());
+}
+
+TEST_F(ProximityAuthBluetoothLowEnergyConnectionTest,
+       Connect_Incomplete_Disconnect_FromWaitingNotifySessionState) {
+  scoped_ptr<MockBluetoothLowEnergyConnection> connection(CreateConnection());
+  ConnectWithExistingGattConnection(connection.get());
+  CharacteristicsFound(connection.get());
+  Disconnect(connection.get());
+}
+
+TEST_F(ProximityAuthBluetoothLowEnergyConnectionTest,
+       Connect_Incomplete_Disconnect_FromWaitingResponseSignalState) {
+  scoped_ptr<MockBluetoothLowEnergyConnection> connection(CreateConnection());
+  ConnectWithExistingGattConnection(connection.get());
+  CharacteristicsFound(connection.get());
+  NotifySessionStarted(connection.get());
+  Disconnect(connection.get());
+}
+
+TEST_F(ProximityAuthBluetoothLowEnergyConnectionTest,
+       Connect_Fails_CharacteristicsNotFound) {
+  scoped_ptr<MockBluetoothLowEnergyConnection> connection(CreateConnection());
+  ConnectWithExistingGattConnection(connection.get());
+
+  EXPECT_CALL(*from_peripheral_char_, StartNotifySession(_, _)).Times(0);
+  EXPECT_FALSE(characteristics_finder_success_callback_.is_null());
+  ASSERT_FALSE(characteristics_finder_error_callback_.is_null());
+
+  characteristics_finder_error_callback_.Run(
+      {to_peripheral_char_uuid_, kToPeripheralCharID},
+      {from_peripheral_char_uuid_, kFromPeripheralCharID});
+
+  EXPECT_EQ(connection->sub_status(),
+            MockBluetoothLowEnergyConnection::SubStatus::DISCONNECTED);
+  EXPECT_EQ(connection->status(), Connection::DISCONNECTED);
+}
+
+TEST_F(ProximityAuthBluetoothLowEnergyConnectionTest,
+       Connect_Fails_NotifySessionError) {
+  scoped_ptr<MockBluetoothLowEnergyConnection> connection(CreateConnection());
+  ConnectWithExistingGattConnection(connection.get());
+  CharacteristicsFound(connection.get());
+
+  EXPECT_CALL(*to_peripheral_char_, WriteRemoteCharacteristic(_, _, _))
+      .Times(0);
+  EXPECT_FALSE(notify_session_success_callback_.is_null());
+  ASSERT_FALSE(notify_session_error_callback_.is_null());
+
+  notify_session_error_callback_.Run(
+      device::BluetoothGattService::GATT_ERROR_UNKNOWN);
+
+  EXPECT_EQ(connection->sub_status(),
+            MockBluetoothLowEnergyConnection::SubStatus::DISCONNECTED);
+  EXPECT_EQ(connection->status(), Connection::DISCONNECTED);
+}
+
+TEST_F(ProximityAuthBluetoothLowEnergyConnectionTest,
+       Connect_Fails_ErrorSendingInviteToConnectSignal) {
+  scoped_ptr<MockBluetoothLowEnergyConnection> connection(CreateConnection());
+  ConnectWithExistingGattConnection(connection.get());
+  CharacteristicsFound(connection.get());
+  NotifySessionStarted(connection.get());
+
+  // |connection| will call WriteRemoteCharacteristics(_,_) to try to send the
+  // message |kMaxNumberOfTries| times. There is alredy one EXPECTA_CALL for
+  // WriteRemoteCharacteristic(_,_,_) in NotifySessionStated, that's why we use
+  // |kMaxNumberOfTries-1| in the EXPECT_CALL statement.
+  EXPECT_CALL(*connection, OnDidSendMessage(_, _)).Times(0);
+  EXPECT_CALL(*to_peripheral_char_, WriteRemoteCharacteristic(_, _, _))
+      .Times(kMaxNumberOfTries - 1)
+      .WillRepeatedly(
+          DoAll(SaveArg<0>(&last_value_written_on_to_peripheral_char_),
+                SaveArg<1>(&write_remote_characteristic_success_callback_),
+                SaveArg<2>(&write_remote_characteristic_error_callback_)));
+
+  for (int i = 0; i < kMaxNumberOfTries; i++) {
+    const std::vector<uint8> kSendSignal = {0, 0, 0, 0};
+    EXPECT_EQ(last_value_written_on_to_peripheral_char_, kSendSignal);
+    ASSERT_FALSE(write_remote_characteristic_error_callback_.is_null());
+    EXPECT_FALSE(write_remote_characteristic_success_callback_.is_null());
+    write_remote_characteristic_error_callback_.Run(
+        device::BluetoothGattService::GATT_ERROR_UNKNOWN);
+  }
+
+  EXPECT_EQ(connection->sub_status(),
+            MockBluetoothLowEnergyConnection::SubStatus::DISCONNECTED);
+  EXPECT_EQ(connection->status(), Connection::DISCONNECTED);
+}
+
+TEST_F(ProximityAuthBluetoothLowEnergyConnectionTest,
+       Connect_Fails_CharacteristicsNotFound_WithoutExistingGattConnection) {
+  scoped_ptr<MockBluetoothLowEnergyConnection> connection(CreateConnection());
+  ConnectWithoutExistingGattConnection(connection.get());
+
+  EXPECT_CALL(*from_peripheral_char_, StartNotifySession(_, _)).Times(0);
+  EXPECT_FALSE(characteristics_finder_success_callback_.is_null());
+  ASSERT_FALSE(characteristics_finder_error_callback_.is_null());
+
+  characteristics_finder_error_callback_.Run(
+      {to_peripheral_char_uuid_, kToPeripheralCharID},
+      {from_peripheral_char_uuid_, kFromPeripheralCharID});
+
+  EXPECT_EQ(connection->sub_status(),
+            MockBluetoothLowEnergyConnection::SubStatus::DISCONNECTED);
+  EXPECT_EQ(connection->status(), Connection::DISCONNECTED);
+}
+
+}  // namespace proximity_auth