Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java

Issue 1144333004: Make WebView work for external displays (over Presentations). Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor naming/comment fixes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java
diff --git a/ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java b/ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java
index 128d961758c91f5146e80d9b254338a9393e22d0..f9e8f91b44a84784a283ab52a6bd285e7bda9193 100644
--- a/ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java
+++ b/ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java
@@ -7,6 +7,7 @@ package org.chromium.ui.base;
import android.app.Activity;
import android.app.PendingIntent;
import android.content.ActivityNotFoundException;
+import android.content.Context;
import android.content.Intent;
import android.content.IntentSender.SendIntentException;
import android.content.SharedPreferences;
@@ -58,7 +59,7 @@ public class ActivityWindowAndroid
* @param activity The activity associated with the WindowAndroid.
*/
public ActivityWindowAndroid(Activity activity) {
- this(activity, true);
+ this(activity, true, activity.getApplicationContext());
boliu 2015/07/15 06:38:46 Should this just be activity? Why is displayContex
gsennton 2015/07/15 19:26:21 activity and displayContext are not always equal (
boliu 2015/07/16 14:36:56 Wait. How do you get to that display context from
gsennton 2015/10/20 13:27:12 In PS11 we pass the activity to the WindowAndroid
boliu 2015/10/20 15:07:22 Looks good.
}
/**
@@ -66,8 +67,9 @@ public class ActivityWindowAndroid
* @param activity The activity associated with the WindowAndroid.
* @param listenToActivityState Whether to listen to activity state changes.
*/
- public ActivityWindowAndroid(Activity activity, boolean listenToActivityState) {
- super(activity.getApplicationContext());
+ public ActivityWindowAndroid(
+ Activity activity, boolean listenToActivityState, Context displayContext) {
+ super(activity.getApplicationContext(), displayContext);
mActivityRef = new WeakReference<Activity>(activity);
mHandler = new Handler();
mOutstandingPermissionRequests = new SparseArray<PermissionCallback>();

Powered by Google App Engine
This is Rietveld 408576698