Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java

Issue 1144333004: Make WebView work for external displays (over Presentations). Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java b/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java
index 79b8ddbb7b366045c553d47fd21c89c4c55d0211..43e4a33017aa3273ed77bbf5d77a72f8c4bb434b 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java
@@ -18,7 +18,6 @@ import android.view.WindowManager;
import org.chromium.base.ObserverList;
import org.chromium.base.ThreadUtils;
import org.chromium.base.VisibleForTesting;
-import org.chromium.ui.gfx.DeviceDisplayInfo;
/**
* ScreenOrientationListener is a class that informs its observers when the
@@ -319,7 +318,7 @@ public class ScreenOrientationListener {
return;
}
- DeviceDisplayInfo.create(mAppContext).updateNativeSharedDisplayInfo();
+ // TODO if we cache DeviceDisplayInfo then update the caches here
boliu 2015/06/01 15:30:18 Hmm, this means native device_display_info shouldn
gsennton 2015/06/04 14:10:29 What's the problem with updating the caches here?
boliu 2015/06/05 04:57:51 Caching is fine. The problem is ui/gfx is its own
for (ScreenOrientationObserver observer : mObservers) {
observer.onScreenOrientationChanged(mOrientation);

Powered by Google App Engine
This is Rietveld 408576698