Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: Source/core/dom/Node.cpp

Issue 1144313003: Added PointerEvent firing on touch events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Node.cpp
diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp
index d6a648772a8c29a04822de6ac13616bf02be98d8..8aa647554f517c7d63841676e6bdf3c717ecae4b 100644
--- a/Source/core/dom/Node.cpp
+++ b/Source/core/dom/Node.cpp
@@ -72,6 +72,7 @@
#include "core/events/KeyboardEvent.h"
#include "core/events/MouseEvent.h"
#include "core/events/MutationEvent.h"
+#include "core/events/PointerEvent.h"
#include "core/events/TextEvent.h"
#include "core/events/TouchEvent.h"
#include "core/events/UIEvent.h"
@@ -2115,6 +2116,8 @@ bool Node::dispatchEvent(PassRefPtrWillBeRawPtr<Event> event)
return EventDispatcher::dispatchEvent(*this, MouseEventDispatchMediator::create(static_pointer_cast<MouseEvent>(event), MouseEventDispatchMediator::SyntheticMouseEvent));
if (event->isTouchEvent())
return dispatchTouchEvent(static_pointer_cast<TouchEvent>(event));
+ if (event->isPointerEvent())
Rick Byers 2015/05/25 18:24:26 This code won't be reached. Your pointer events s
mustaq 2015/05/26 15:00:09 Done.
+ return dispatchPointerEvent(static_pointer_cast<PointerEvent>(event));
Rick Byers 2015/05/25 18:24:26 Any idea why we need this special case at all? Pr
mustaq 2015/05/26 15:00:09 It seems none of the 57 callers to dispatchEvent()
return EventDispatcher::dispatchEvent(*this, EventDispatchMediator::create(event));
}
@@ -2164,6 +2167,11 @@ bool Node::dispatchTouchEvent(PassRefPtrWillBeRawPtr<TouchEvent> event)
return EventDispatcher::dispatchEvent(*this, TouchEventDispatchMediator::create(event));
}
+bool Node::dispatchPointerEvent(PassRefPtrWillBeRawPtr<PointerEvent> event)
+{
+ return EventDispatcher::dispatchEvent(*this, PointerEventDispatchMediator::create(event));
+}
+
void Node::dispatchSimulatedClick(Event* underlyingEvent, SimulatedClickMouseEventOptions eventOptions)
{
EventDispatcher::dispatchSimulatedClick(*this, underlyingEvent, eventOptions);

Powered by Google App Engine
This is Rietveld 408576698