BiDiLineIterator: Remove "url" parameter.

BiDiLineIterator: Remove "url" parameter.

This parameter is always passed "false", and it doesn't do anything
sensible if you pass "true". It purports to be processing bidi text for
a URL, but it does not do anything of the sort.

Specifically, if the overall text direction of the string is RTL, it
tells ICU to use the UBIDI_REORDER_RUNS_ONLY algorithm, which disables
the bidi algorithm and places all strong characters (LTR and RTL) at
Level 0. This is not designed to produce a display ordering and has
nothing to do with the formatting requirements for a URL. It might have
made sense back when BiDiLineIterator was solely used by
AutocompleteResultView in 2008 (it did some sort of post processing on
the reversed runs), but I don't want this misleading parameter to stay
around now.

BUG=351639
Committed: https://crrev.com/8b2bdeaa0e5bc7dbb50017bd0e6ee1c6ecc22dee
Cr-Commit-Position: refs/heads/master@{#333687}

[Matt Giuca, 2015-06-03 07:05:40]

mgiuca@chromium.org changed reviewers:
+ jshin@chromium.org, msw@chromium.org

[Matt Giuca, 2015-06-03 07:05:41]

jshin@chromium.org: Please review changes in bidi_line_iterator.
msw@chromium.org: Please review changes in render_text_harfbuzz.

For a bit more motivation: I was trying to solve crbug.com/351639 and found this
parameter. It didn't do what it says. I'm not quite sure what it is *supposed*
to do, but the docs
(http://icu-project.org/apiref/icu4c55m1/ubidi_8h.html#afe123acc1196c4d7363f96...)
say it's a logical -> logical transformation, not at all what BiDiLineIterator
is for, so I decided it was best to remove it to avoid confusion.

[msw, 2015-06-03 16:49:42]

render_text_harfbuzz lgtm

[Matt Giuca, 2015-06-09 04:34:50]

jshin: ping.

[jungshik at Google, 2015-06-09 22:51:15]

On 2015/06/09 04:34:50, Matt Giuca wrote:
> jshin: ping.

Ooops. Sorry. LGTM

[Matt Giuca, 2015-06-10 04:25:20]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-06-10 04:25:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144303004/1

[commit-bot: I haz the power, 2015-06-10 05:53:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-10 05:54:11]

Patchset 1 (id:??) landed as
https://crrev.com/8b2bdeaa0e5bc7dbb50017bd0e6ee1c6ecc22dee
Cr-Commit-Position: refs/heads/master@{#333687}