lib/src/codegen/js_codegen.dart - Issue 1144303003: Use signature inheritance when method types are unchanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1144303003: Use signature inheritance when method types are unchanged (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/js_codegen.dart

diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart

index 1808bf3a1e50ad3dd4710dcfaa2d84b77efaee76..466b73058f84309c4e9f7af6d9b63546b860f7b8 100644

--- a/lib/src/codegen/js_codegen.dart

+++ b/lib/src/codegen/js_codegen.dart

@@ -592,6 +592,10 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {

if (!(node.isSetter || node.isGetter || node.isAbstract)) {

var name = node.name.name;

var element = node.element;

+ var inheritedElement =

+ classElem.lookUpInheritedConcreteMethod(name, currentLibrary);

+ if (inheritedElement != null &&

+ inheritedElement.type == element.type) continue;

var unary = node.parameters.parameters.isEmpty;

var memberName = _emitMemberName(name,

type: cType, unary: unary, isStatic: node.isStatic);