Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/runtime/dart/core.js

Issue 1144303003: Use signature inheritance when method types are unchanged (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/runtime/dart/async.js ('K') | « lib/runtime/dart/convert.js ('k') | lib/runtime/dart/isolate.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/core.js
diff --git a/lib/runtime/dart/core.js b/lib/runtime/dart/core.js
index f47c21245fa17232301ec4ffca979b50b926781f..b299e98495a05adc6162b78cf13bc768aac8daa4 100644
--- a/lib/runtime/dart/core.js
+++ b/lib/runtime/dart/core.js
@@ -66,9 +66,7 @@ var convert = dart.lazyImport(convert);
return `Deprecated feature. Will be removed ${this.expires}`;
}
}
- dart.setSignature(Deprecated, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(Deprecated, {});
class _Override extends Object {
_Override() {
}
@@ -92,9 +90,7 @@ var convert = dart.lazyImport(convert);
}
}
dart.defineNamedConstructor(bool, 'fromEnvironment');
- dart.setSignature(bool, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(bool, {});
let Comparator$ = dart.generic(function(T) {
let Comparator = dart.typedef('Comparator', () => dart.functionType(int, [T, T]));
return Comparator;
@@ -365,14 +361,12 @@ var convert = dart.lazyImport(convert);
dart.defineNamedConstructor(DateTime, '_now');
dart.setSignature(DateTime, {
methods: () => ({
- '==': dart.functionType(bool, [dart.dynamic]),
isBefore: dart.functionType(bool, [DateTime]),
isAfter: dart.functionType(bool, [DateTime]),
isAtSameMomentAs: dart.functionType(bool, [DateTime]),
compareTo: dart.functionType(int, [DateTime]),
toLocal: dart.functionType(DateTime, []),
toUtc: dart.functionType(DateTime, []),
- toString: dart.functionType(String, []),
toIso8601String: dart.functionType(String, []),
add: dart.functionType(DateTime, [Duration]),
subtract: dart.functionType(DateTime, [Duration]),
@@ -581,9 +575,7 @@ var convert = dart.lazyImport(convert);
'>': dart.functionType(bool, [Duration]),
'<=': dart.functionType(bool, [Duration]),
'>=': dart.functionType(bool, [Duration]),
- '==': dart.functionType(bool, [dart.dynamic]),
compareTo: dart.functionType(int, [Duration]),
- toString: dart.functionType(String, []),
abs: dart.functionType(Duration, []),
'unary-': dart.functionType(Duration, [])
})
@@ -656,9 +648,7 @@ var convert = dart.lazyImport(convert);
return "Throw of null.";
}
}
- dart.setSignature(NullThrownError, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(NullThrownError, {});
let _hasValue = dart.JsSymbol('_hasValue');
class ArgumentError extends Error {
ArgumentError(message) {
@@ -703,9 +693,7 @@ var convert = dart.lazyImport(convert);
}
dart.defineNamedConstructor(ArgumentError, 'value');
dart.defineNamedConstructor(ArgumentError, 'notNull');
- dart.setSignature(ArgumentError, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(ArgumentError, {});
class RangeError extends ArgumentError {
RangeError(message) {
this.start = null;
@@ -808,7 +796,6 @@ var convert = dart.lazyImport(convert);
dart.defineNamedConstructor(RangeError, 'range');
dart.defineNamedConstructor(RangeError, 'index');
dart.setSignature(RangeError, {
- methods: () => ({toString: dart.functionType(String, [])}),
statics: () => ({
checkValueInInterval: dart.functionType(dart.void, [int, int, int], [String, String]),
checkValidIndex: dart.functionType(dart.void, [int, dart.dynamic], [String, int, String]),
@@ -846,9 +833,7 @@ var convert = dart.lazyImport(convert);
}
}
IndexError[dart.implements] = () => [RangeError];
- dart.setSignature(IndexError, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(IndexError, {});
class FallThroughError extends Error {
FallThroughError() {
super.Error();
@@ -865,9 +850,7 @@ var convert = dart.lazyImport(convert);
return `Cannot instantiate abstract class: '${this[_className]}'`;
}
}
- dart.setSignature(AbstractClassInstantiationError, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(AbstractClassInstantiationError, {});
let _receiver = dart.JsSymbol('_receiver');
let _memberName = dart.JsSymbol('_memberName');
let _arguments = dart.JsSymbol('_arguments');
@@ -924,9 +907,7 @@ var convert = dart.lazyImport(convert);
}
}
}
- dart.setSignature(NoSuchMethodError, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(NoSuchMethodError, {});
class UnsupportedError extends Error {
UnsupportedError(message) {
this.message = message;
@@ -936,9 +917,7 @@ var convert = dart.lazyImport(convert);
return `Unsupported operation: ${this.message}`;
}
}
- dart.setSignature(UnsupportedError, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(UnsupportedError, {});
class UnimplementedError extends Error {
UnimplementedError(message) {
if (message === void 0)
@@ -951,9 +930,7 @@ var convert = dart.lazyImport(convert);
}
}
UnimplementedError[dart.implements] = () => [UnsupportedError];
- dart.setSignature(UnimplementedError, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(UnimplementedError, {});
class StateError extends Error {
StateError(message) {
this.message = message;
@@ -963,9 +940,7 @@ var convert = dart.lazyImport(convert);
return `Bad state: ${this.message}`;
}
}
- dart.setSignature(StateError, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(StateError, {});
class ConcurrentModificationError extends Error {
ConcurrentModificationError(modifiedObject) {
if (modifiedObject === void 0)
@@ -980,9 +955,7 @@ var convert = dart.lazyImport(convert);
return "Concurrent modification during iteration: " + `${Error.safeToString(this.modifiedObject)}.`;
}
}
- dart.setSignature(ConcurrentModificationError, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(ConcurrentModificationError, {});
class OutOfMemoryError extends Object {
OutOfMemoryError() {
}
@@ -994,9 +967,7 @@ var convert = dart.lazyImport(convert);
}
}
OutOfMemoryError[dart.implements] = () => [Error];
- dart.setSignature(OutOfMemoryError, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(OutOfMemoryError, {});
class StackOverflowError extends Object {
StackOverflowError() {
}
@@ -1008,9 +979,7 @@ var convert = dart.lazyImport(convert);
}
}
StackOverflowError[dart.implements] = () => [Error];
- dart.setSignature(StackOverflowError, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(StackOverflowError, {});
class CyclicInitializationError extends Error {
CyclicInitializationError(variableName) {
if (variableName === void 0)
@@ -1022,9 +991,7 @@ var convert = dart.lazyImport(convert);
return this.variableName == null ? "Reading static variable during its initialization" : `Reading static variable '${this.variableName}' during its initialization`;
}
}
- dart.setSignature(CyclicInitializationError, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(CyclicInitializationError, {});
class Exception extends Object {
Exception(message) {
if (message === void 0)
@@ -1046,9 +1013,7 @@ var convert = dart.lazyImport(convert);
}
}
_ExceptionImplementation[dart.implements] = () => [Exception];
- dart.setSignature(_ExceptionImplementation, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(_ExceptionImplementation, {});
class FormatException extends Object {
FormatException(message, source, offset) {
if (message === void 0)
@@ -1138,9 +1103,7 @@ var convert = dart.lazyImport(convert);
}
}
FormatException[dart.implements] = () => [Exception];
- dart.setSignature(FormatException, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(FormatException, {});
class IntegerDivisionByZeroException extends Object {
IntegerDivisionByZeroException() {
}
@@ -1149,9 +1112,7 @@ var convert = dart.lazyImport(convert);
}
}
IntegerDivisionByZeroException[dart.implements] = () => [Exception];
- dart.setSignature(IntegerDivisionByZeroException, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(IntegerDivisionByZeroException, {});
let _getKey = dart.JsSymbol('_getKey');
let Expando$ = dart.generic(function(T) {
class Expando extends Object {
@@ -1191,7 +1152,6 @@ var convert = dart.lazyImport(convert);
}
dart.setSignature(Expando, {
methods: () => ({
- toString: dart.functionType(String, []),
get: dart.functionType(T, [Object]),
set: dart.functionType(dart.void, [Object, T]),
[_getKey]: dart.functionType(String, [])
@@ -1831,7 +1791,6 @@ var convert = dart.lazyImport(convert);
[$any]: dart.functionType(bool, [dart.functionType(bool, [E])]),
[$every]: dart.functionType(bool, [dart.functionType(bool, [E])]),
[$contains]: dart.functionType(bool, [Object]),
- [$toString]: dart.functionType(String, []),
[$toList]: dart.functionType(List$(E), [], {rowabl: bool}),
[$toSet]: dart.functionType(exports.Set$(E), []),
[$get]: dart.functionType(E, [int]),
@@ -1899,9 +1858,7 @@ var convert = dart.lazyImport(convert);
}
}
dart.defineNamedConstructor(Null, '_uninstantiable');
- dart.setSignature(Null, {
- methods: () => ({toString: dart.functionType(String, [])})
- });
+ dart.setSignature(Null, {});
num._parseError = false;
class Pattern extends Object {}
dart.setSignature(Pattern, {});
@@ -2300,7 +2257,6 @@ var convert = dart.lazyImport(convert);
writeAll: dart.functionType(dart.void, [Iterable], [String]),
writeln: dart.functionType(dart.void, [], [Object]),
clear: dart.functionType(dart.void, []),
- toString: dart.functionType(String, []),
[_writeString]: dart.functionType(dart.void, [dart.dynamic])
})
});
@@ -3590,9 +3546,7 @@ var convert = dart.lazyImport(convert);
toFilePath: dart.functionType(String, [], {indow: bool}),
[_toFilePath]: dart.functionType(String, []),
[_toWindowsFilePath]: dart.functionType(String, []),
- [_writeAuthority]: dart.functionType(dart.void, [StringSink]),
- toString: dart.functionType(String, []),
- '==': dart.functionType(bool, [dart.dynamic])
+ [_writeAuthority]: dart.functionType(dart.void, [StringSink])
}),
statics: () => ({
_defaultPort: dart.functionType(int, [String]),
« lib/runtime/dart/async.js ('K') | « lib/runtime/dart/convert.js ('k') | lib/runtime/dart/isolate.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698