Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/runtime/dart/collection.js

Issue 1144303003: Use signature inheritance when method types are unchanged (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/runtime/dart/async.js ('K') | « lib/runtime/dart/async.js ('k') | lib/runtime/dart/convert.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/collection.js
diff --git a/lib/runtime/dart/collection.js b/lib/runtime/dart/collection.js
index 98efd009a84457e3c8c084a56af0776712bbf571..8128b529382e5577e7ad64618f9d3b3294946722 100644
--- a/lib/runtime/dart/collection.js
+++ b/lib/runtime/dart/collection.js
@@ -388,7 +388,6 @@ var math = dart.lazyImport(math);
difference: dart.functionType(core.Set$(E), [core.Set$(core.Object)]),
[core.$toList]: dart.functionType(core.List$(E), [], {rowabl: core.bool}),
[core.$map]: dart.functionType(core.Iterable, [dart.functionType(dart.dynamic, [E])]),
- toString: dart.functionType(core.String, []),
[core.$where]: dart.functionType(core.Iterable$(E), [dart.functionType(core.bool, [E])]),
[core.$expand]: dart.functionType(core.Iterable, [dart.functionType(core.Iterable, [E])]),
[core.$forEach]: dart.functionType(dart.void, [dart.functionType(dart.void, [E])]),
@@ -742,8 +741,7 @@ var math = dart.lazyImport(math);
[core.$firstWhere]: dart.functionType(E, [dart.functionType(core.bool, [E])], {rEls: dart.functionType(E, [])}),
[core.$lastWhere]: dart.functionType(E, [dart.functionType(core.bool, [E])], {rEls: dart.functionType(E, [])}),
[core.$singleWhere]: dart.functionType(E, [dart.functionType(core.bool, [E])]),
- [core.$elementAt]: dart.functionType(E, [core.int]),
- toString: dart.functionType(core.String, [])
+ [core.$elementAt]: dart.functionType(E, [core.int])
})
});
return IterableMixin;
@@ -1113,8 +1111,7 @@ var math = dart.lazyImport(math);
[core.$firstWhere]: dart.functionType(E, [dart.functionType(core.bool, [E])], {rEls: dart.functionType(E, [])}),
[core.$lastWhere]: dart.functionType(E, [dart.functionType(core.bool, [E])], {rEls: dart.functionType(E, [])}),
[core.$singleWhere]: dart.functionType(E, [dart.functionType(core.bool, [E])]),
- [core.$elementAt]: dart.functionType(E, [core.int]),
- toString: dart.functionType(core.String, [])
+ [core.$elementAt]: dart.functionType(E, [core.int])
}),
statics: () => ({
iterableToShortString: dart.functionType(core.String, [core.Iterable], [core.String, core.String]),
@@ -2034,8 +2031,7 @@ var math = dart.lazyImport(math);
[core.$insert]: dart.functionType(dart.void, [core.int, E]),
[core.$removeAt]: dart.functionType(E, [core.int]),
[core.$insertAll]: dart.functionType(dart.void, [core.int, core.Iterable$(E)]),
- [core.$setAll]: dart.functionType(dart.void, [core.int, core.Iterable$(E)]),
- [core.$toString]: dart.functionType(core.String, [])
+ [core.$setAll]: dart.functionType(dart.void, [core.int, core.Iterable$(E)])
}),
statics: () => ({_filter: dart.functionType(dart.void, [core.List, dart.functionType(core.bool, [dart.dynamic]), core.bool])}),
names: ['_filter']
@@ -2111,8 +2107,7 @@ var math = dart.lazyImport(math);
addAll: dart.functionType(dart.void, [core.Map$(K, V)]),
containsValue: dart.functionType(core.bool, [core.Object]),
putIfAbsent: dart.functionType(V, [K, dart.functionType(V, [])]),
- containsKey: dart.functionType(core.bool, [core.Object]),
- toString: dart.functionType(core.String, [])
+ containsKey: dart.functionType(core.bool, [core.Object])
})
});
return MapMixin;
@@ -2293,8 +2288,7 @@ var math = dart.lazyImport(math);
containsKey: dart.functionType(core.bool, [core.Object]),
containsValue: dart.functionType(core.bool, [core.Object]),
forEach: dart.functionType(dart.void, [dart.functionType(dart.void, [K, V])]),
- remove: dart.functionType(V, [core.Object]),
- toString: dart.functionType(core.String, [])
+ remove: dart.functionType(V, [core.Object])
})
});
return MapView;
@@ -2677,8 +2671,7 @@ var math = dart.lazyImport(math);
lastEntry: dart.functionType(DoubleLinkedQueueEntry$(E), []),
firstEntry: dart.functionType(DoubleLinkedQueueEntry$(E), []),
clear: dart.functionType(dart.void, []),
- forEachEntry: dart.functionType(dart.void, [dart.functionType(dart.void, [DoubleLinkedQueueEntry$(E)])]),
- toString: dart.functionType(core.String, [])
+ forEachEntry: dart.functionType(dart.void, [dart.functionType(dart.void, [DoubleLinkedQueueEntry$(E)])])
})
});
return DoubleLinkedQueue;
@@ -3021,7 +3014,6 @@ var math = dart.lazyImport(math);
removeWhere: dart.functionType(dart.void, [dart.functionType(core.bool, [E])]),
retainWhere: dart.functionType(dart.void, [dart.functionType(core.bool, [E])]),
clear: dart.functionType(dart.void, []),
- toString: dart.functionType(core.String, []),
addLast: dart.functionType(dart.void, [E]),
addFirst: dart.functionType(dart.void, [E]),
removeFirst: dart.functionType(E, []),
@@ -3501,7 +3493,6 @@ var math = dart.lazyImport(math);
clear: dart.functionType(dart.void, []),
containsKey: dart.functionType(core.bool, [core.Object]),
containsValue: dart.functionType(core.bool, [core.Object]),
- toString: dart.functionType(core.String, []),
firstKey: dart.functionType(K, []),
lastKey: dart.functionType(K, []),
lastKeyBefore: dart.functionType(K, [K]),
@@ -3861,17 +3852,13 @@ var math = dart.lazyImport(math);
add: dart.functionType(core.bool, [E]),
remove: dart.functionType(core.bool, [core.Object]),
addAll: dart.functionType(dart.void, [core.Iterable$(E)]),
- removeAll: dart.functionType(dart.void, [core.Iterable$(core.Object)]),
- retainAll: dart.functionType(dart.void, [core.Iterable$(core.Object)]),
lookup: dart.functionType(E, [core.Object]),
intersection: dart.functionType(core.Set$(E), [core.Set$(core.Object)]),
difference: dart.functionType(core.Set$(E), [core.Set$(core.Object)]),
union: dart.functionType(core.Set$(E), [core.Set$(E)]),
[_clone]: dart.functionType(SplayTreeSet$(E), []),
[_copyNode]: dart.functionType(_SplayTreeNode$(E), [_SplayTreeNode$(E)]),
- clear: dart.functionType(dart.void, []),
- [core.$toSet]: dart.functionType(core.Set$(E), []),
- toString: dart.functionType(core.String, [])
+ [core.$toSet]: dart.functionType(core.Set$(E), [])
})
});
return SplayTreeSet;
@@ -4222,12 +4209,7 @@ var math = dart.lazyImport(math);
return -1;
}
}
- dart.setSignature(_IdentityHashMap, {
- methods: () => ({
- [_computeHashCode]: dart.functionType(core.int, [dart.dynamic]),
- [_findBucketIndex]: dart.functionType(core.int, [dart.dynamic, dart.dynamic])
- })
- });
+ dart.setSignature(_IdentityHashMap, {});
return _IdentityHashMap;
});
let _IdentityHashMap = _IdentityHashMap$();
@@ -4282,11 +4264,7 @@ var math = dart.lazyImport(math);
methods: () => ({
get: dart.functionType(V, [core.Object]),
set: dart.functionType(dart.void, [K, V]),
- containsKey: dart.functionType(core.bool, [core.Object]),
- remove: dart.functionType(V, [core.Object]),
- [_computeHashCode]: dart.functionType(core.int, [dart.dynamic]),
- [_findBucketIndex]: dart.functionType(core.int, [dart.dynamic, dart.dynamic]),
- toString: dart.functionType(core.String, [])
+ remove: dart.functionType(V, [core.Object])
})
});
return _CustomHashMap;
@@ -4323,10 +4301,7 @@ var math = dart.lazyImport(math);
}
HashMapKeyIterable[dart.implements] = () => [_internal.EfficientLength];
dart.setSignature(HashMapKeyIterable, {
- methods: () => ({
- [core.$contains]: dart.functionType(core.bool, [core.Object]),
- [core.$forEach]: dart.functionType(dart.void, [dart.functionType(dart.void, [E])])
- })
+ methods: () => ({[core.$forEach]: dart.functionType(dart.void, [dart.functionType(dart.void, [E])])})
});
return HashMapKeyIterable;
});
@@ -4672,8 +4647,7 @@ var math = dart.lazyImport(math);
[_unlinkCell]: dart.functionType(dart.void, [LinkedHashMapCell]),
[_computeHashCode]: dart.functionType(core.int, [dart.dynamic]),
[_getBucket]: dart.functionType(core.List, [dart.dynamic, dart.dynamic]),
- [_findBucketIndex]: dart.functionType(core.int, [dart.dynamic, dart.dynamic]),
- toString: dart.functionType(core.String, [])
+ [_findBucketIndex]: dart.functionType(core.int, [dart.dynamic, dart.dynamic])
}),
statics: () => ({
_isStringKey: dart.functionType(core.bool, [dart.dynamic]),
@@ -4708,12 +4682,7 @@ var math = dart.lazyImport(math);
return -1;
}
}
- dart.setSignature(_LinkedIdentityHashMap, {
- methods: () => ({
- [_computeHashCode]: dart.functionType(core.int, [dart.dynamic]),
- [_findBucketIndex]: dart.functionType(core.int, [dart.dynamic, dart.dynamic])
- })
- });
+ dart.setSignature(_LinkedIdentityHashMap, {});
return _LinkedIdentityHashMap;
});
let _LinkedIdentityHashMap = _LinkedIdentityHashMap$();
@@ -4764,10 +4733,7 @@ var math = dart.lazyImport(math);
methods: () => ({
get: dart.functionType(V, [core.Object]),
set: dart.functionType(dart.void, [K, V]),
- containsKey: dart.functionType(core.bool, [core.Object]),
- remove: dart.functionType(V, [core.Object]),
- [_computeHashCode]: dart.functionType(core.int, [dart.dynamic]),
- [_findBucketIndex]: dart.functionType(core.int, [dart.dynamic, dart.dynamic])
+ remove: dart.functionType(V, [core.Object])
})
});
return _LinkedCustomHashMap;
@@ -4815,10 +4781,7 @@ var math = dart.lazyImport(math);
}
LinkedHashMapKeyIterable[dart.implements] = () => [_internal.EfficientLength];
dart.setSignature(LinkedHashMapKeyIterable, {
- methods: () => ({
- [core.$contains]: dart.functionType(core.bool, [core.Object]),
- [core.$forEach]: dart.functionType(dart.void, [dart.functionType(dart.void, [E])])
- })
+ methods: () => ({[core.$forEach]: dart.functionType(dart.void, [dart.functionType(dart.void, [E])])})
});
return LinkedHashMapKeyIterable;
});
@@ -5103,7 +5066,6 @@ var math = dart.lazyImport(math);
addAll: dart.functionType(dart.void, [core.Iterable$(E)]),
remove: dart.functionType(core.bool, [core.Object]),
[_remove]: dart.functionType(core.bool, [core.Object]),
- clear: dart.functionType(dart.void, []),
[_computeElements]: dart.functionType(core.List, []),
[_addHashTableEntry]: dart.functionType(core.bool, [dart.dynamic, E]),
[_removeHashTableEntry]: dart.functionType(core.bool, [dart.dynamic, core.Object]),
@@ -5147,11 +5109,7 @@ var math = dart.lazyImport(math);
}
}
dart.setSignature(_IdentityHashSet, {
- methods: () => ({
- [_newSet]: dart.functionType(core.Set$(E), []),
- [_computeHashCode]: dart.functionType(core.int, [dart.dynamic]),
- [_findBucketIndex]: dart.functionType(core.int, [dart.dynamic, dart.dynamic])
- })
+ methods: () => ({[_newSet]: dart.functionType(core.Set$(E), [])})
});
return _IdentityHashSet;
});
@@ -5205,12 +5163,8 @@ var math = dart.lazyImport(math);
dart.setSignature(_CustomHashSet, {
methods: () => ({
[_newSet]: dart.functionType(core.Set$(E), []),
- [_findBucketIndex]: dart.functionType(core.int, [dart.dynamic, dart.dynamic]),
- [_computeHashCode]: dart.functionType(core.int, [dart.dynamic]),
add: dart.functionType(core.bool, [E]),
- [core.$contains]: dart.functionType(core.bool, [core.Object]),
- lookup: dart.functionType(E, [core.Object]),
- remove: dart.functionType(core.bool, [core.Object])
+ lookup: dart.functionType(E, [core.Object])
})
});
return _CustomHashSet;
@@ -5541,7 +5495,6 @@ var math = dart.lazyImport(math);
removeWhere: dart.functionType(dart.void, [dart.functionType(core.bool, [E])]),
retainWhere: dart.functionType(dart.void, [dart.functionType(core.bool, [E])]),
[_filterWhere]: dart.functionType(dart.void, [dart.functionType(core.bool, [E]), core.bool]),
- clear: dart.functionType(dart.void, []),
[_addHashTableEntry]: dart.functionType(core.bool, [dart.dynamic, E]),
[_removeHashTableEntry]: dart.functionType(core.bool, [dart.dynamic, core.Object]),
[_modified]: dart.functionType(dart.void, []),
@@ -5588,11 +5541,7 @@ var math = dart.lazyImport(math);
}
}
dart.setSignature(_LinkedIdentityHashSet, {
- methods: () => ({
- [_newSet]: dart.functionType(core.Set$(E), []),
- [_computeHashCode]: dart.functionType(core.int, [dart.dynamic]),
- [_findBucketIndex]: dart.functionType(core.int, [dart.dynamic, dart.dynamic])
- })
+ methods: () => ({[_newSet]: dart.functionType(core.Set$(E), [])})
});
return _LinkedIdentityHashSet;
});
@@ -5659,14 +5608,8 @@ var math = dart.lazyImport(math);
dart.setSignature(_LinkedCustomHashSet, {
methods: () => ({
[_newSet]: dart.functionType(core.Set$(E), []),
- [_findBucketIndex]: dart.functionType(core.int, [dart.dynamic, dart.dynamic]),
- [_computeHashCode]: dart.functionType(core.int, [dart.dynamic]),
add: dart.functionType(core.bool, [E]),
- [core.$contains]: dart.functionType(core.bool, [core.Object]),
- lookup: dart.functionType(E, [core.Object]),
- remove: dart.functionType(core.bool, [core.Object]),
- containsAll: dart.functionType(core.bool, [core.Iterable$(core.Object)]),
- removeAll: dart.functionType(dart.void, [core.Iterable$(core.Object)])
+ lookup: dart.functionType(E, [core.Object])
})
});
return _LinkedCustomHashSet;
« lib/runtime/dart/async.js ('K') | « lib/runtime/dart/async.js ('k') | lib/runtime/dart/convert.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698