Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Unified Diff: lib/runtime/dart/async.js

Issue 1144303003: Use signature inheritance when method types are unchanged (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/_native_typed_data.js ('k') | lib/runtime/dart/collection.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/async.js
diff --git a/lib/runtime/dart/async.js b/lib/runtime/dart/async.js
index cf36e1209f6e963468829df9143805e036e4042a..bc753f5ac82d0908d0b923748dc0bee2b637e4d9 100644
--- a/lib/runtime/dart/async.js
+++ b/lib/runtime/dart/async.js
@@ -32,9 +32,7 @@ var collection = dart.import(collection);
}
}
AsyncError[dart.implements] = () => [core.Error];
- dart.setSignature(AsyncError, {
- methods: () => ({toString: dart.functionType(core.String, [])})
- });
+ dart.setSignature(AsyncError, {});
class _UncaughtAsyncError extends AsyncError {
_UncaughtAsyncError(error, stackTrace) {
super.AsyncError(error, _UncaughtAsyncError._getBestStackTrace(error, stackTrace));
@@ -56,7 +54,6 @@ var collection = dart.import(collection);
}
}
dart.setSignature(_UncaughtAsyncError, {
- methods: () => ({toString: dart.functionType(core.String, [])}),
statics: () => ({_getBestStackTrace: dart.functionType(core.StackTrace, [dart.dynamic, core.StackTrace])}),
names: ['_getBestStackTrace']
});
@@ -1231,13 +1228,7 @@ var collection = dart.import(collection);
this[_controller][_recordResume](this);
}
}
- dart.setSignature(_ControllerSubscription, {
- methods: () => ({
- [_onCancel]: dart.functionType(Future, []),
- [_onPause]: dart.functionType(dart.void, []),
- [_onResume]: dart.functionType(dart.void, [])
- })
- });
+ dart.setSignature(_ControllerSubscription, {});
Jennifer Messerly 2015/05/20 20:16:22 we could skip empty signatures too?
Leaf 2015/05/20 20:41:36 Done.
return _ControllerSubscription;
});
let _ControllerSubscription = _ControllerSubscription$();
@@ -1283,9 +1274,7 @@ var collection = dart.import(collection);
methods: () => ({
[_expectsEvent]: dart.functionType(core.bool, [core.int]),
[_toggleEventId]: dart.functionType(dart.void, []),
- [_setRemoveAfterFiring]: dart.functionType(dart.void, []),
- [_onPause]: dart.functionType(dart.void, []),
- [_onResume]: dart.functionType(dart.void, [])
+ [_setRemoveAfterFiring]: dart.functionType(dart.void, [])
})
});
return _BroadcastSubscription;
@@ -1703,10 +1692,7 @@ var collection = dart.import(collection);
dart.setSignature(_AsBroadcastStreamController, {
methods: () => ({
[_addPendingEvent]: dart.functionType(dart.void, [_DelayedEvent]),
- add: dart.functionType(dart.void, [T]),
- addError: dart.functionType(dart.void, [core.Object], [core.StackTrace]),
- close: dart.functionType(Future, []),
- [_callOnCancel]: dart.functionType(dart.void, [])
+ add: dart.functionType(dart.void, [T])
})
});
return _AsBroadcastStreamController;
@@ -1797,9 +1783,7 @@ var collection = dart.import(collection);
}
}
DeferredLoadException[dart.implements] = () => [core.Exception];
- dart.setSignature(DeferredLoadException, {
- methods: () => ({toString: dart.functionType(core.String, [])})
- });
+ dart.setSignature(DeferredLoadException, {});
let _completeWithValue = Symbol('_completeWithValue');
let Future$ = dart.generic(function(T) {
class Future extends core.Object {
@@ -1995,9 +1979,7 @@ var collection = dart.import(collection);
}
}
TimeoutException[dart.implements] = () => [core.Exception];
- dart.setSignature(TimeoutException, {
- methods: () => ({toString: dart.functionType(core.String, [])})
- });
+ dart.setSignature(TimeoutException, {});
let Completer$ = dart.generic(function(T) {
class Completer extends core.Object {
Completer() {
@@ -4244,10 +4226,6 @@ var collection = dart.import(collection);
dart.setSignature(_ForwardingStreamSubscription, {
methods: () => ({
[_add]: dart.functionType(dart.void, [T]),
- [_addError]: dart.functionType(dart.void, [core.Object, core.StackTrace]),
- [_onPause]: dart.functionType(dart.void, []),
- [_onResume]: dart.functionType(dart.void, []),
- [_onCancel]: dart.functionType(Future, []),
[_handleData]: dart.functionType(dart.void, [S]),
[_handleError]: dart.functionType(dart.void, [dart.dynamic, core.StackTrace]),
[_handleDone]: dart.functionType(dart.void, [])
@@ -4695,11 +4673,6 @@ var collection = dart.import(collection);
dart.setSignature(_SinkTransformerStreamSubscription, {
methods: () => ({
[_add]: dart.functionType(dart.void, [T]),
- [_addError]: dart.functionType(dart.void, [core.Object, core.StackTrace]),
- [_close]: dart.functionType(dart.void, []),
- [_onPause]: dart.functionType(dart.void, []),
- [_onResume]: dart.functionType(dart.void, []),
- [_onCancel]: dart.functionType(Future, []),
[_handleData]: dart.functionType(dart.void, [S]),
[_handleError]: dart.functionType(dart.void, [dart.dynamic], [dart.dynamic]),
[_handleDone]: dart.functionType(dart.void, [])
« no previous file with comments | « lib/runtime/dart/_native_typed_data.js ('k') | lib/runtime/dart/collection.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698