Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1892)

Unified Diff: lib/runtime/dart/_internal.js

Issue 1144303003: Use signature inheritance when method types are unchanged (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/runtime/dart/_internal.js
diff --git a/lib/runtime/dart/_internal.js b/lib/runtime/dart/_internal.js
index d2e2a9b939d902d672c0f3d80a11fcc7657e0a32..f1bda6fa7dc3b0a8f712027579397202e7a3232d 100644
--- a/lib/runtime/dart/_internal.js
+++ b/lib/runtime/dart/_internal.js
@@ -242,13 +242,11 @@ var _js_primitives = dart.lazyImport(_js_primitives);
dart.setSignature(ListIterable, {
methods: () => ({
[core.$forEach]: dart.functionType(dart.void, [dart.functionType(dart.void, [E])]),
- [core.$contains]: dart.functionType(core.bool, [core.Object]),
[core.$every]: dart.functionType(core.bool, [dart.functionType(core.bool, [E])]),
[core.$any]: dart.functionType(core.bool, [dart.functionType(core.bool, [E])]),
[core.$firstWhere]: dart.functionType(E, [dart.functionType(core.bool, [E])], {rEls: dart.functionType(E, [])}),
[core.$lastWhere]: dart.functionType(E, [dart.functionType(core.bool, [E])], {rEls: dart.functionType(E, [])}),
[core.$singleWhere]: dart.functionType(E, [dart.functionType(core.bool, [E])]),
- [core.$join]: dart.functionType(core.String, [], [core.String]),
[core.$where]: dart.functionType(core.Iterable$(E), [dart.functionType(core.bool, [E])]),
[core.$map]: dart.functionType(core.Iterable, [dart.functionType(dart.dynamic, [E])]),
[core.$reduce]: dart.functionType(E, [dart.functionType(E, [dart.dynamic, E])]),
@@ -958,13 +956,11 @@ var _js_primitives = dart.lazyImport(_js_primitives);
methods: () => ({
[core.$forEach]: dart.functionType(dart.void, [dart.functionType(dart.void, [E])]),
[core.$elementAt]: dart.functionType(E, [core.int]),
- [core.$contains]: dart.functionType(core.bool, [core.Object]),
[core.$every]: dart.functionType(core.bool, [dart.functionType(core.bool, [E])]),
[core.$any]: dart.functionType(core.bool, [dart.functionType(core.bool, [E])]),
[core.$firstWhere]: dart.functionType(E, [dart.functionType(core.bool, [E])], {rEls: dart.functionType(E, [])}),
[core.$lastWhere]: dart.functionType(E, [dart.functionType(core.bool, [E])], {rEls: dart.functionType(E, [])}),
[core.$singleWhere]: dart.functionType(E, [dart.functionType(core.bool, [E])], {rEls: dart.functionType(E, [])}),
- [core.$join]: dart.functionType(core.String, [], [core.String]),
[core.$where]: dart.functionType(core.Iterable$(E), [dart.functionType(core.bool, [E])]),
[core.$map]: dart.functionType(core.Iterable, [dart.functionType(dart.dynamic, [E])]),
[core.$reduce]: dart.functionType(E, [dart.functionType(E, [E, E])]),
@@ -1752,8 +1748,7 @@ var _js_primitives = dart.lazyImport(_js_primitives);
putIfAbsent: dart.functionType(E, [core.int, dart.functionType(E, [])]),
remove: dart.functionType(E, [core.Object]),
clear: dart.functionType(dart.void, []),
- addAll: dart.functionType(dart.void, [core.Map$(core.int, E)]),
- toString: dart.functionType(core.String, [])
+ addAll: dart.functionType(dart.void, [core.Map$(core.int, E)])
})
});
return ListMapView;
@@ -2216,10 +2211,7 @@ var _js_primitives = dart.lazyImport(_js_primitives);
dart.defineNamedConstructor(Symbol, 'unvalidated');
dart.defineNamedConstructor(Symbol, 'validated');
dart.setSignature(Symbol, {
- methods: () => ({
- '==': dart.functionType(core.bool, [core.Object]),
- toString: dart.functionType(core.String, [])
- }),
+ methods: () => ({'==': dart.functionType(core.bool, [core.Object])}),
statics: () => ({
getName: dart.functionType(core.String, [Symbol]),
validatePublicSymbol: dart.functionType(core.String, [core.String]),

Powered by Google App Engine
This is Rietveld 408576698