Replaced vector with set for current_jobs_.

chrome/browser/printing/print_job_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_job_manager.h"
 
 #include "chrome/browser/printing/print_job.h"
 #include "chrome/browser/printing/printer_query.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "content/public/browser/notification_service.h"
@@ skipping 88 matching lines @@
   switch (event_details.type()) {
     case JobEventDetails::NEW_DOC: {
       DCHECK(current_jobs_.end() == std::find(current_jobs_.begin(),
                                               current_jobs_.end(),
                                               print_job));
       // Causes a AddRef().
       current_jobs_.push_back(make_scoped_refptr(print_job));
       break;
     }
     case JobEventDetails::JOB_DONE: {
-      PrintJobs::iterator itr = std::find(current_jobs_.begin(),
-                                          current_jobs_.end(),
-                                          print_job);
-      DCHECK(current_jobs_.end() != itr);
-      current_jobs_.erase(itr);
-      DCHECK(current_jobs_.end() == std::find(current_jobs_.begin(),
-                                              current_jobs_.end(),
-                                              print_job));
-      destination_ = NULL;
+      DCHECK(std::count(current_jobs_.begin(),
+                        current_jobs_.end(), print_job) == 1);
+      RemoveJob(print_job);
       break;
     }
     case JobEventDetails::FAILED: {
-      PrintJobs::iterator itr = std::find(current_jobs_.begin(),
-                                          current_jobs_.end(),
-                                          print_job);
-      // A failed job may have never started.
-      if (current_jobs_.end() != itr) {
-        current_jobs_.erase(itr);
-        DCHECK(current_jobs_.end() ==
-                  std::find(current_jobs_.begin(),
-                            current_jobs_.end(),
-                            print_job));
-      }
+      DCHECK(std::count(current_jobs_.begin(),

[gene, 2012/12/05 21:52:31]

I think this check makes more sense in RemoveJob()

[Vitaly Buka (NO REVIEWS), 2012/12/05 23:27:42]

Done.

+                        current_jobs_.end(), print_job) <= 1);
+      RemoveJob(print_job);
       break;
     }
     case JobEventDetails::USER_INIT_DONE:
     case JobEventDetails::USER_INIT_CANCELED:
     case JobEventDetails::DEFAULT_INIT_DONE:
     case JobEventDetails::NEW_PAGE:
     case JobEventDetails::PAGE_DONE:
     case JobEventDetails::DOC_DONE:
     case JobEventDetails::ALL_PAGES_REQUESTED: {
       // Don't care.
       break;
     }
     default: {
       NOTREACHED();
       break;
     }
   }
 }
 
+void PrintJobManager::RemoveJob(PrintJob* print_job) {

[gene, 2012/12/05 21:52:31]

I think it will be easier to read if you iterate current_jobs_ in a loop and
erase element as soon as you found it.

[Vitaly Buka (NO REVIEWS), 2012/12/05 23:27:42]

Done.

+  current_jobs_.erase(std::remove(current_jobs_.begin(), current_jobs_.end(),
+                                  print_job),
+                      current_jobs_.end());
+}
+
 }  // namespace printing