Issue - 7123

vm/symbols.h

Index: vm/symbols.h
===================================================================
--- vm/symbols.h	(revision 15744)
+++ vm/symbols.h	(working copy)
@@ -216,7 +216,11 @@
 
   // Helper functions to create a symbol given a string or set of characters.
   template<typename T>

[cshapiro, 2012/12/05 20:40:16]

I would rename T to CharacterType and add a CallbackType parameter to replace
the New signature below or, create a typedef for it.

[siva, 2012/12/05 23:33:14]

Done.

-  static RawString* NewSymbol(const T* characters, intptr_t len);
+  static RawString* NewSymbol(const T* characters,
+                              intptr_t len,
+                              RawString* (*New)(const T* chars,

[cshapiro, 2012/12/05 20:40:16]

s/New/new_string/

(Can't call it new because that is a reserved word, need to make it lower case
to match the style guide.)

[siva, 2012/12/05 23:33:14]

Done.

+                                                intptr_t len,
+                                                Heap::Space space));
 
   // Add the string into the VM isolate symbol table.
   static void Add(const Array& symbol_table, const String& str);