Issue - 7123

vm/object.h

Index: vm/object.h
===================================================================
--- vm/object.h	(revision 15744)
+++ vm/object.h	(working copy)
@@ -3828,22 +3828,19 @@
                              Heap::Space space = Heap::kNew);
 
   // Creates a new String object from an array of Latin-1 encoded characters.
-  // TODO(7123) - Rename this to FromLatin1(....).
-  static RawString* New(const uint8_t* latin1_array,
-                        intptr_t array_len,
-                        Heap::Space space = Heap::kNew);
+  static RawString* FromLatin1(const uint8_t* latin1_array,
+                               intptr_t array_len,
+                               Heap::Space space = Heap::kNew);
 
   // Creates a new String object from an array of UTF-16 encoded characters.
-  // TODO(7123) - Rename this to FromUTF16(....).
-  static RawString* New(const uint16_t* utf16_array,
-                        intptr_t array_len,
-                        Heap::Space space = Heap::kNew);
+  static RawString* FromUTF16(const uint16_t* utf16_array,
+                              intptr_t array_len,
+                              Heap::Space space = Heap::kNew);
 
   // Creates a new String object from an array of UTF-32 encoded characters.
-  // TODO(7123) - Rename this to FromUTF32(....).
-  static RawString* New(const int32_t* utf32_array,
-                        intptr_t array_len,
-                        Heap::Space space = Heap::kNew);
+  static RawString* FromUTF32(const int32_t* utf32_array,
+                              intptr_t array_len,
+                              Heap::Space space = Heap::kNew);
 
   // Create a new String object from another Dart String instance.
   static RawString* New(const String& str, Heap::Space space = Heap::kNew);
@@ -3930,6 +3927,8 @@
                            String* str_obj,
                            intptr_t len,
                            intptr_t tags,
+                           RawString* (*NewSymbol)(const ElementType* chars,

[cshapiro, 2012/12/05 20:40:16]

You can greatly simplify this by having the callback declared as a template
parameter

  template<typename HandleType, typename ElementType, typename CallbackType>
  static void ReadFromImpl(...
                           CallbackType new_symbol,
                           ...)

Either way, NewSymbol should be new_symbol since it is an argument.

[siva, 2012/12/05 23:33:14]

Done.

+                                                   intptr_t len),
                            Snapshot::Kind kind);
 
   HEAP_OBJECT_IMPLEMENTATION(String, Instance);