Issue - 7123

vm/symbols.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_SYMBOLS_H_
 #define VM_SYMBOLS_H_
 
 #include "vm/object.h"
 #include "vm/snapshot_ids.h"
 
@@ skipping 197 matching lines @@
     return reinterpret_cast<RawString**>(&predefined_);
   }
 
  private:
   enum {
     kInitialVMIsolateSymtabSize = ((kMaxId + 15) & -16),
     kInitialSymtabSize = 256
   };
 
   // Helper functions to create a symbol given a string or set of characters.
   template<typename T>

[cshapiro, 2012/12/05 20:40:16]

I would rename T to CharacterType and add a CallbackType parameter to replace
the New signature below or, create a typedef for it.

[siva, 2012/12/05 23:33:14]

Done.

-  static RawString* NewSymbol(const T* characters, intptr_t len);
+  static RawString* NewSymbol(const T* characters,
+                              intptr_t len,
+                              RawString* (*New)(const T* chars,

[cshapiro, 2012/12/05 20:40:16]

s/New/new_string/

(Can't call it new because that is a reserved word, need to make it lower case
to match the style guide.)

[siva, 2012/12/05 23:33:14]

Done.

+                                                intptr_t len,
+                                                Heap::Space space));
 
   // Add the string into the VM isolate symbol table.
   static void Add(const Array& symbol_table, const String& str);
 
   // Insert symbol into symbol table, growing it if necessary.
   static void InsertIntoSymbolTable(const Array& symbol_table,
                                     const String& symbol,
                                     intptr_t index);
 
   // Grow the symbol table.
@@ skipping 25 matching lines @@
   friend class SnapshotReader;
   friend class SnapshotWriter;
   friend class ApiMessageReader;
 
   DISALLOW_COPY_AND_ASSIGN(Symbols);
 };
 
 }  // namespace dart
 
 #endif  // VM_SYMBOLS_H_