Issue - 7123

vm/symbols.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/symbols.h"
 
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/raw_object.h"
@@ skipping 89 matching lines @@
 RawString* Symbols::New(const char* cstr) {
   ASSERT(cstr != NULL);
   intptr_t array_len = strlen(cstr);
   const uint8_t* utf8_array = reinterpret_cast<const uint8_t*>(cstr);
   return Symbols::FromUTF8(utf8_array, array_len);
 }
 
 
 RawString* Symbols::FromUTF8(const uint8_t* utf8_array, intptr_t array_len) {
   if (array_len == 0 || utf8_array == NULL) {
-    return NewSymbol(reinterpret_cast<uint8_t*>(NULL), 0);
+    return FromLatin1(reinterpret_cast<uint8_t*>(NULL), 0);
   }
   Utf8::Type type;
   intptr_t len = Utf8::CodeUnitCount(utf8_array, array_len, &type);
   ASSERT(len != 0);
   Zone* zone = Isolate::Current()->current_zone();
   if (type == Utf8::kLatin1) {
     uint8_t* characters = zone->Alloc<uint8_t>(len);
     Utf8::DecodeToLatin1(utf8_array, array_len, characters, len);
-    return NewSymbol(characters, len);
+    return FromLatin1(characters, len);
   }
   ASSERT((type == Utf8::kBMP) || (type == Utf8::kSupplementary));
   uint16_t* characters = zone->Alloc<uint16_t>(len);
   Utf8::DecodeToUTF16(utf8_array, array_len, characters, len);
-  return NewSymbol(characters, len);
+  return FromUTF16(characters, len);
 }
 
 
 RawString* Symbols::FromLatin1(const uint8_t* latin1_array, intptr_t len) {
-  return NewSymbol(latin1_array, len);
+  return NewSymbol(latin1_array, len, String::FromLatin1);
 }
 
 
 RawString* Symbols::FromUTF16(const uint16_t* utf16_array, intptr_t len) {
-  return NewSymbol(utf16_array, len);
+  return NewSymbol(utf16_array, len, String::FromUTF16);
 }
 
 
 RawString* Symbols::FromUTF32(const int32_t* utf32_array, intptr_t len) {
-  return NewSymbol(utf32_array, len);
+  return NewSymbol(utf32_array, len, String::FromUTF32);
 }
 
 
 template<typename T>
-RawString* Symbols::NewSymbol(const T* characters, intptr_t len) {
+RawString* Symbols::NewSymbol(const T* characters,
+                              intptr_t len,
+                              RawString* (*New)(const T* chars,

[cshapiro, 2012/12/05 20:40:16]

rename New, possibly to new_string

[siva, 2012/12/05 23:33:14]

Done.

+                                                intptr_t len,
+                                                Heap::Space space)) {
   Isolate* isolate = Isolate::Current();
   String& symbol = String::Handle(isolate, String::null());
   Array& symbol_table = Array::Handle(isolate, Array::null());
 
   // Calculate the String hash for this sequence of characters.
   intptr_t hash = String::Hash(characters, len);
 
   // First check if a symbol exists in the vm isolate for these characters.
   symbol_table = Dart::vm_isolate()->object_store()->symbol_table();
   intptr_t index = FindIndex(symbol_table, characters, len, hash);
   symbol ^= symbol_table.At(index);
   if (symbol.IsNull()) {
     // Now try in the symbol table of the current isolate.
     symbol_table = isolate->object_store()->symbol_table();
     index = FindIndex(symbol_table, characters, len, hash);
     // Since we leave enough room in the table to guarantee, that we find an
     // empty spot, index is the insertion point if symbol is null.
     symbol ^= symbol_table.At(index);
     if (symbol.IsNull()) {
       // Allocate new result string.
-      symbol = String::New(characters, len, Heap::kOld);
+      symbol = (*New)(characters, len, Heap::kOld);
       symbol.SetHash(hash);  // Remember the calculated hash value.
       InsertIntoSymbolTable(symbol_table, symbol, index);
     }
   }
   ASSERT(symbol.IsSymbol());
   return symbol.raw();
 }
 
 
 template RawString* Symbols::NewSymbol(const uint8_t* characters,
-                                       intptr_t len);
+                                       intptr_t len,
+                                       RawString* (*New)(const uint8_t* chars,

[cshapiro, 2012/12/05 20:40:16]

ditto on the rename here and in the two cases below

[siva, 2012/12/05 23:33:14]

Done.

+                                                         intptr_t len,
+                                                         Heap::Space space));
 template RawString* Symbols::NewSymbol(const uint16_t* characters,
-                                       intptr_t len);
+                                       intptr_t len,
+                                       RawString* (*New)(const uint16_t* chars,
+                                                         intptr_t len,
+                                                         Heap::Space space));
 template RawString* Symbols::NewSymbol(const int32_t* characters,
-                                       intptr_t len);
+                                       intptr_t len,
+                                       RawString* (*New)(const int32_t* chars,
+                                                         intptr_t len,
+                                                         Heap::Space space));
 
 
 RawString* Symbols::New(const String& str) {
   if (str.IsSymbol()) {
     return str.raw();
   }
   return New(str, 0, str.Length());
 }
 
 
@@ skipping 157 matching lines @@
 }
 
 
 RawObject* Symbols::GetVMSymbol(intptr_t object_id) {
   ASSERT(IsVMSymbolId(object_id));
   intptr_t i = (object_id - kMaxPredefinedObjectIds);
   return (i > 0 && i < Symbols::kMaxId) ? predefined_[i] : Object::null();
 }
 
 }  // namespace dart