Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: cc/layer_animation_controller.cc

Issue 11443004: Maintain global lists of animation controllers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layer_animation_controller.cc
diff --git a/cc/layer_animation_controller.cc b/cc/layer_animation_controller.cc
index 805f8fc264d5fbf7fae71609a0a77241a662caeb..f20669e9226364068997d0eebf8c27d86dcba3d7 100644
--- a/cc/layer_animation_controller.cc
+++ b/cc/layer_animation_controller.cc
@@ -10,19 +10,23 @@
namespace cc {
-LayerAnimationController::LayerAnimationController(LayerAnimationControllerClient* client)
+LayerAnimationController::LayerAnimationController(AnimationRegistrar::ThreadName threadName)
: m_forceSync(false)
- , m_client(client)
+ , m_id(-1)
+ , m_opacity(1.0)
+ , m_threadName(threadName)
{
+ AnimationRegistrar::Register(this, m_threadName);
}
LayerAnimationController::~LayerAnimationController()
{
+ AnimationRegistrar::Unregister(this, m_threadName);
}
-scoped_ptr<LayerAnimationController> LayerAnimationController::create(LayerAnimationControllerClient* client)
+scoped_refptr<LayerAnimationController> LayerAnimationController::create(AnimationRegistrar::ThreadName threadName)
{
- return make_scoped_ptr(new LayerAnimationController(client));
+ return make_scoped_refptr(new LayerAnimationController(threadName));
}
void LayerAnimationController::pauseAnimation(int animationId, double timeOffset)
@@ -41,6 +45,7 @@ void LayerAnimationController::removeAnimation(int animationId)
else
i++;
}
+ updateActivation();
}
void LayerAnimationController::removeAnimation(int animationId, ActiveAnimation::TargetProperty targetProperty)
@@ -51,6 +56,7 @@ void LayerAnimationController::removeAnimation(int animationId, ActiveAnimation:
else
i++;
}
+ updateActivation();
}
// According to render layer backing, these are for testing only.
@@ -75,6 +81,12 @@ void LayerAnimationController::resumeAnimations(double monotonicTime)
// are kept in sync.
void LayerAnimationController::pushAnimationUpdatesTo(LayerAnimationController* controllerImpl)
{
+ if (!isAnimatingProperty(ActiveAnimation::Opacity))
+ controllerImpl->m_opacity = m_opacity;
+
+ if (!isAnimatingProperty(ActiveAnimation::Transform))
+ controllerImpl->m_transform = m_transform;
+
if (m_forceSync) {
replaceImplThreadAnimations(controllerImpl);
m_forceSync = false;
@@ -100,11 +112,14 @@ void LayerAnimationController::animate(double monotonicTime, AnimationEventsVect
tickAnimations(monotonicTime);
markAnimationsForDeletion(monotonicTime, events);
startAnimationsWaitingForTargetAvailability(monotonicTime, events);
+
+ updateActivation();
}
void LayerAnimationController::addAnimation(scoped_ptr<ActiveAnimation> animation)
{
m_activeAnimations.append(animation.Pass());
+ updateActivation();
}
ActiveAnimation* LayerAnimationController::getActiveAnimation(int groupId, ActiveAnimation::TargetProperty targetProperty) const
@@ -154,9 +169,25 @@ void LayerAnimationController::notifyAnimationStarted(const AnimationEvent& even
}
}
-void LayerAnimationController::setClient(LayerAnimationControllerClient* client)
+void LayerAnimationController::setId(int id)
+{
+ m_id = id;
+}
+
+bool LayerAnimationController::setOpacity(float opacity)
{
- m_client = client;
+ if (m_opacity == opacity || isAnimatingProperty(ActiveAnimation::Opacity))
+ return false;
+ m_opacity = opacity;
+ return true;
+}
+
+bool LayerAnimationController::setTransform(const gfx::Transform& transform)
+{
+ if (m_transform == transform || isAnimatingProperty(ActiveAnimation::Transform))
+ return false;
+ m_transform = transform;
+ return true;
}
void LayerAnimationController::pushNewAnimationsToImplThread(LayerAnimationController* controllerImpl) const
@@ -214,7 +245,7 @@ void LayerAnimationController::startAnimationsWaitingForNextTick(double monotoni
if (!m_activeAnimations[i]->hasSetStartTime())
m_activeAnimations[i]->setStartTime(monotonicTime);
if (events)
- events->push_back(AnimationEvent(AnimationEvent::Started, m_client->id(), m_activeAnimations[i]->group(), m_activeAnimations[i]->targetProperty(), monotonicTime));
+ events->push_back(AnimationEvent(AnimationEvent::Started, m_id, m_activeAnimations[i]->group(), m_activeAnimations[i]->targetProperty(), monotonicTime));
}
}
}
@@ -225,7 +256,7 @@ void LayerAnimationController::startAnimationsWaitingForStartTime(double monoton
if (m_activeAnimations[i]->runState() == ActiveAnimation::WaitingForStartTime && m_activeAnimations[i]->startTime() <= monotonicTime) {
m_activeAnimations[i]->setRunState(ActiveAnimation::Running, monotonicTime);
if (events)
- events->push_back(AnimationEvent(AnimationEvent::Started, m_client->id(), m_activeAnimations[i]->group(), m_activeAnimations[i]->targetProperty(), monotonicTime));
+ events->push_back(AnimationEvent(AnimationEvent::Started, m_id, m_activeAnimations[i]->group(), m_activeAnimations[i]->targetProperty(), monotonicTime));
}
}
}
@@ -264,7 +295,7 @@ void LayerAnimationController::startAnimationsWaitingForTargetAvailability(doubl
if (!m_activeAnimations[i]->hasSetStartTime())
m_activeAnimations[i]->setStartTime(monotonicTime);
if (events)
- events->push_back(AnimationEvent(AnimationEvent::Started, m_client->id(), m_activeAnimations[i]->group(), m_activeAnimations[i]->targetProperty(), monotonicTime));
+ events->push_back(AnimationEvent(AnimationEvent::Started, m_id, m_activeAnimations[i]->group(), m_activeAnimations[i]->targetProperty(), monotonicTime));
for (size_t j = i + 1; j < m_activeAnimations.size(); ++j) {
if (m_activeAnimations[i]->group() == m_activeAnimations[j]->group()) {
m_activeAnimations[j]->setRunState(ActiveAnimation::Running, monotonicTime);
@@ -320,7 +351,7 @@ void LayerAnimationController::markAnimationsForDeletion(double monotonicTime, A
for (size_t j = i; j < m_activeAnimations.size(); j++) {
if (groupId == m_activeAnimations[j]->group()) {
if (events)
- events->push_back(AnimationEvent(AnimationEvent::Finished, m_client->id(), m_activeAnimations[j]->group(), m_activeAnimations[j]->targetProperty(), monotonicTime));
+ events->push_back(AnimationEvent(AnimationEvent::Finished, m_id, m_activeAnimations[j]->group(), m_activeAnimations[j]->targetProperty(), monotonicTime));
m_activeAnimations[j]->setRunState(ActiveAnimation::WaitingForDeletion, monotonicTime);
}
}
@@ -358,7 +389,7 @@ void LayerAnimationController::replaceImplThreadAnimations(LayerAnimationControl
void LayerAnimationController::tickAnimations(double monotonicTime)
{
- for (size_t i = 0; i < m_activeAnimations.size(); ++i) {
+ for (size_t i = 0; i < m_activeAnimations.size(); ++i) {
if (m_activeAnimations[i]->runState() == ActiveAnimation::Running || m_activeAnimations[i]->runState() == ActiveAnimation::Paused) {
double trimmed = m_activeAnimations[i]->trimTimeToCurrentIteration(monotonicTime);
@@ -371,21 +402,17 @@ void LayerAnimationController::tickAnimations(double monotonicTime)
case ActiveAnimation::Transform: {
const TransformAnimationCurve* transformAnimationCurve = m_activeAnimations[i]->curve()->toTransformAnimationCurve();
- const gfx::Transform matrix = transformAnimationCurve->getValue(trimmed).toTransform();
+ m_transform = transformAnimationCurve->getValue(trimmed).toTransform();
if (m_activeAnimations[i]->isFinishedAt(monotonicTime))
m_activeAnimations[i]->setRunState(ActiveAnimation::Finished, monotonicTime);
-
- m_client->setTransformFromAnimation(matrix);
break;
}
case ActiveAnimation::Opacity: {
const FloatAnimationCurve* floatAnimationCurve = m_activeAnimations[i]->curve()->toFloatAnimationCurve();
- const float opacity = floatAnimationCurve->getValue(trimmed);
+ m_opacity = floatAnimationCurve->getValue(trimmed);
if (m_activeAnimations[i]->isFinishedAt(monotonicTime))
m_activeAnimations[i]->setRunState(ActiveAnimation::Finished, monotonicTime);
-
- m_client->setOpacityFromAnimation(opacity);
break;
}
@@ -397,4 +424,12 @@ void LayerAnimationController::tickAnimations(double monotonicTime)
}
}
+void LayerAnimationController::updateActivation()
+{
+ if (hasActiveAnimation())
+ AnimationRegistrar::Activate(this, m_threadName);
+ else
+ AnimationRegistrar::Deactivate(this, m_threadName);
+}
+
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698