Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 1144273003: Omnibox - Improve HQP's Also-Do-HUP-Like-Scoring Mode (Closed)

Created:
5 years, 7 months ago by Mark P
Modified:
5 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox - Improve HQP's Also-Do-HUP-Like-Scoring Mode I noticed that HistoryQuick provider's also-do-HUP-like-scoring mode did some score-capping to prevent a non-inlineable match from showing first. This is no longer necessary now that we have reorder mode (a.k.a. the allowed_to_be_default_match field). BUG= Committed: https://crrev.com/7312fb3dd37518935e3d676a698e5392803a5da2 Cr-Commit-Position: refs/heads/master@{#330812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M chrome/browser/autocomplete/scored_history_match.cc View 3 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark P
Hi Peter, I think this is a no-brainer. Take a look. Maybe I'll re-try this ...
5 years, 7 months ago (2015-05-20 19:06:47 UTC) #2
Peter Kasting
LGTM
5 years, 7 months ago (2015-05-20 19:56:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144273003/1
5 years, 7 months ago (2015-05-20 20:26:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 21:58:34 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 21:59:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7312fb3dd37518935e3d676a698e5392803a5da2
Cr-Commit-Position: refs/heads/master@{#330812}

Powered by Google App Engine
This is Rietveld 408576698