Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1144263002: Dropping iterations and speedup from perf results. (Closed)

Created:
5 years, 7 months ago by bradn
Modified:
5 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Dropping iterations and speedup from perf results. The dashboard displays everything on one scale. This isn't very useful. Dropping these two fields as they're not really that interesting anyway. BUG=https://code.google.com/p/v8/issues/detail?id=4124 LOG=N TEST=None NOTRY=true TBR=machenbach@chromium.org Committed: https://crrev.com/d04de62be3169045e4b0a7e3bbbf1dcbb234d1d5 Cr-Commit-Position: refs/heads/master@{#28548}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -142 lines) Patch
M test/simdjs/SimdJs.json View 1 18 chunks +2 lines, -138 lines 0 comments Download
M test/simdjs/generate.py View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
bradn
5 years, 7 months ago (2015-05-20 18:39:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144263002/1
5 years, 7 months ago (2015-05-20 18:39:35 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-20 18:39:37 UTC) #5
Michael Achenbach
lgtm https://codereview.chromium.org/1144263002/diff/1/test/simdjs/generate.py File test/simdjs/generate.py (right): https://codereview.chromium.org/1144263002/diff/1/test/simdjs/generate.py#newcode35 test/simdjs/generate.py:35: 'timeout_android_arm': 120, Could you bump the timeout on ...
5 years, 7 months ago (2015-05-21 10:14:26 UTC) #6
bradn
https://codereview.chromium.org/1144263002/diff/1/test/simdjs/generate.py File test/simdjs/generate.py (right): https://codereview.chromium.org/1144263002/diff/1/test/simdjs/generate.py#newcode35 test/simdjs/generate.py:35: 'timeout_android_arm': 120, On 2015/05/21 10:14:26, Michael Achenbach wrote: > ...
5 years, 7 months ago (2015-05-21 12:45:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144263002/20001
5 years, 7 months ago (2015-05-21 12:45:50 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 12:49:43 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 12:49:56 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d04de62be3169045e4b0a7e3bbbf1dcbb234d1d5
Cr-Commit-Position: refs/heads/master@{#28548}

Powered by Google App Engine
This is Rietveld 408576698