Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1590)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1144253003: Remove --enable-strict-site-isolation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Set correct upstream Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index f67a40a2a53ed746c35dccead80b3d1f505057bb..0a1c3568eeb2022e3612c542841d8abd51374ba2 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -4150,34 +4150,6 @@ WebNavigationPolicy RenderFrameImpl::DecidePolicyForNavigation(
bool is_content_initiated =
document_state->navigation_state()->IsContentInitiated();
- // Experimental:
- // If --enable-strict-site-isolation is enabled, send all top-level
- // navigations to the browser to let it swap processes when crossing site
- // boundaries. This is currently expected to break some script calls and
- // navigations, such as form submissions.
- bool force_swap_due_to_flag =
- command_line.HasSwitch(switches::kEnableStrictSiteIsolation);
- if (force_swap_due_to_flag &&
- !info.frame->parent() && (is_content_initiated || info.isRedirect)) {
- WebString origin_str = info.frame->document().securityOrigin().toString();
- GURL frame_url(origin_str.utf8().data());
- // TODO(cevans): revisit whether this site check is still necessary once
- // crbug.com/101395 is fixed.
- bool same_domain_or_host =
- net::registry_controlled_domains::SameDomainOrHost(
- frame_url,
- url,
- net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES);
- // Only keep same-site (domain + scheme) and data URLs in the same process.
- bool is_same_site =
- (same_domain_or_host && frame_url.scheme() == url.scheme()) ||
- url.SchemeIs(url::kDataScheme);
- if (!is_same_site) {
- OpenURL(info.frame, url, referrer, info.defaultPolicy);
- return blink::WebNavigationPolicyIgnore;
- }
- }
-
// If the browser is interested, then give it a chance to look at the request.
if (is_content_initiated) {
bool is_form_post =
« content/browser/site_instance_impl_unittest.cc ('K') | « content/public/common/content_switches.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698