Sky: Convert TransferMode to an enum.

Sky: Convert TransferMode to an enum.

It looked and smelled like an enum, so lets just make it one. This also gives us a nice toString() method.

R=abarth@chromium.org, eseidel@chromium.org, ianh@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/5ad89c28cfc5dc934b7fe694e66bce2f92e16541

[Matt Perry, 2015-06-03 19:32:59]

mpcomplete@chromium.org changed reviewers:
+ eseidel@chromium.org

[kulakowski, 2015-06-03 19:36:31]

kulakowski@chromium.org changed reviewers:
+ kulakowski@chromium.org

[kulakowski, 2015-06-03 19:36:32]

https://codereview.chromium.org/1144233004/diff/1/sky/engine/core/painting/Tr...
File sky/engine/core/painting/TransferMode.dart (right):

https://codereview.chromium.org/1144233004/diff/1/sky/engine/core/painting/Tr...
sky/engine/core/painting/TransferMode.dart:26: //
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blending
This url breaks for me:

An error occurred while processing your request

compositing/index.html@1b29fccda155: not found in manifest

https://codereview.chromium.org/1144233004/diff/1/sky/engine/core/painting/Tr...
sky/engine/core/painting/TransferMode.dart:38: multiplyMode,  /// The last
seperable mode.
Spelling: separable

[abarth-chromium, 2015-06-03 19:39:15]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2015-06-03 19:39:16]

lgtm

[eseidel, 2015-06-03 19:39:36]

eseidel@chromium.org changed reviewers:
- abarth@chromium.org

[eseidel, 2015-06-03 19:39:36]

Other than what george said, lgtm.

[Hixie, 2015-06-03 19:43:55]

ianh@google.com changed reviewers:
+ abarth@chromium.org, ianh@google.com

[Hixie, 2015-06-03 19:43:55]

lgtm

https://codereview.chromium.org/1144233004/diff/1/sky/engine/core/painting/Tr...
File sky/engine/core/painting/TransferMode.dart (right):

https://codereview.chromium.org/1144233004/diff/1/sky/engine/core/painting/Tr...
sky/engine/core/painting/TransferMode.dart:8: /// SkXfermode.h and the values
(order) should be kept in sync.
Can the conversion from SkXfermode.h be automatic, if they have to be kept in
sync?

[Matt Perry, 2015-06-03 19:57:48]

https://codereview.chromium.org/1144233004/diff/1/sky/engine/core/painting/Tr...
File sky/engine/core/painting/TransferMode.dart (right):

https://codereview.chromium.org/1144233004/diff/1/sky/engine/core/painting/Tr...
sky/engine/core/painting/TransferMode.dart:8: /// SkXfermode.h and the values
(order) should be kept in sync.
On 2015/06/03 19:43:55, Hixie wrote:
> Can the conversion from SkXfermode.h be automatic, if they have to be kept in
> sync?

It could, but the last change to these values was 2013, so I don't think it's
worth the effort. I added a compile assert to at least warn us when it does
change.

https://codereview.chromium.org/1144233004/diff/1/sky/engine/core/painting/Tr...
sky/engine/core/painting/TransferMode.dart:26: //
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blending
On 2015/06/03 19:36:32, kulakowski wrote:
> This url breaks for me:
> 
> An error occurred while processing your request
> 
> compositing/index.html@1b29fccda155: not found in manifest

I pulled it from the Skia source. I'll delete it.

[Hixie, 2015-06-03 20:10:48]

lgtm

https://codereview.chromium.org/1144233004/diff/20001/sky/engine/core/paintin...
File sky/engine/core/painting/TransferMode.cpp (right):

https://codereview.chromium.org/1144233004/diff/20001/sky/engine/core/paintin...
sky/engine/core/painting/TransferMode.cpp:18:
COMPILE_ASSERT(SkXfermode::kLastMode == 28, Need_to_update_TransferMode_dart);
that's great.

[Matt Perry, 2015-06-03 20:19:17]

Committed patchset #2 (id:20001) manually as
5ad89c28cfc5dc934b7fe694e66bce2f92e16541 (presubmit successful).