Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1144223002: Avoid excessive GCs in small heaps. (Closed)

Created:
5 years, 7 months ago by ulan
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid excessive GCs in small heaps. Small heaps and small heap growing factor can lead to excessive GCs in corner cases. Consider function F(old_gen_size, factor) that returns the number of bytes that have to be allocated in the old generation to start incremental marking. F(4MB, 1.1) = 4MB (because of kMinimumOldGenerationAllocationLimit) F(6MB, 1.1) = 2MB (because of kMinimumOldGenerationAllocationLimit) F(8MB, 1.1) = 800KB Funtion F should be monotonic in old_gen_size, but it currently has a minimum at kMinimumOldGenerationAllocationLimit. This CL makes F monotonic. BUG= Committed: https://crrev.com/22b1da99732b4db0754bf267ec470a2831216fb2 Cr-Commit-Position: refs/heads/master@{#28549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
PTAL
5 years, 7 months ago (2015-05-20 17:48:52 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 7 months ago (2015-05-21 12:21:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144223002/1
5 years, 7 months ago (2015-05-21 12:23:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 12:50:49 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/22b1da99732b4db0754bf267ec470a2831216fb2 Cr-Commit-Position: refs/heads/master@{#28549}
5 years, 7 months ago (2015-05-21 12:51:06 UTC) #7
ulan
5 years, 7 months ago (2015-05-21 14:46:54 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1152533002/ by ulan@chromium.org.

The reason for reverting is: Regressed Sunspider..

Powered by Google App Engine
This is Rietveld 408576698