[Media Galleries] Add an ImageCaptureCore listener for Mac. (part 2)

chrome/browser/system_monitor/image_capture_device_browser_mac.h

Index: chrome/browser/system_monitor/image_capture_device_browser_mac.h
diff --git a/chrome/browser/system_monitor/image_capture_device_browser_mac.h b/chrome/browser/system_monitor/image_capture_device_browser_mac.h
new file mode 100644
index 0000000000000000000000000000000000000000..568340c50c818a0bd72e74e975fc1451e48f184f
--- /dev/null
+++ b/chrome/browser/system_monitor/image_capture_device_browser_mac.h
@@ -0,0 +1,43 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYSTEM_MONITOR_IMAGE_CAPTURE_DEVICE_MAC_H_
+#define CHROME_BROWSER_SYSTEM_MONITOR_IMAGE_CAPTURE_DEVICE_MAC_H_
+
+#import <Foundation/Foundation.h>
+#import <ImageCaptureCore/ImageCaptureCore.h>
+
+#include "base/file_path.h"
+#include "base/memory/scoped_nsobject.h"
+#include "base/platform_file.h"
+#include "base/string_util.h"
+#include "base/sys_string_conversions.h"
+
+@class ImageCaptureCameraInterface;
+@class ImageCaptureDeviceBrowserMac;
+
+namespace chrome {
+
+// This wrapper basically allows the owner to have a scoped_ptr rather than a
+// scoped_nsobject, isolating the Objective-C parts of the implementation away.
+class ImageCaptureDeviceBrowser {

[sail, 2012/12/14 01:26:32]

I think SystemMonitorICDeviceBrowser would be a better name

[Greg Billock, 2012/12/14 18:59:11]

I suspect we'll end up not going through SystemMonitor at all. We do need to
resolve that approach, though.

[sail, 2012/12/14 19:27:32]

Sorry, I wasn't referring to the base/system_monitor API. I was referring to the
module this code is in (chrome/browser/system_monitor). Ideally this should be
named to reflect the module.

[Greg Billock, 2012/12/14 22:03:56]

Ah, hmmm. We haven't really followed that elsewhere here, and I worry it'd be
confusing. To me what these classes do is provide a wrapper on the ImageCapture
library, so that's the main feature of their name.

On 2012/12/14 19:27:32, sail wrote:

[sail, 2012/12/14 22:14:48]

In ui/cocoa/* we normally name the class after the feature it's implementing and
not the API its using.

For example, instead of MyTableDelegate it would be TaskManagerTableDelegate.
This helps avoid confusion where we have lots of table delegates but they all do
different things.

+ public:
+  ImageCaptureDeviceBrowser();
+  ~ImageCaptureDeviceBrowser();
+
+  // The UUIDs passed here are available in the device attach notifications
+  // given through SystemMonitor. They're gotten by cracking the device ID
+  // and taking the unique ID output.
+  static ImageCaptureCameraInterface* cameraInterfaceForUUID(
+      const std::string& uuid);
+
+ private:
+  scoped_nsobject<ImageCaptureDeviceBrowserMac> device_browser_;
+};
+
+}  // namespace chrome
+
+
+
+#endif   // CHROME_BROWSER_SYSTEM_MONITOR_IMAGE_CAPTURE_DEVICE_MAC_H_