Issue 11442054: Remove over-zealous hole checking in Array.slice()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11442054: Remove over-zealous hole checking in Array.slice() (Closed)

Created:
8 years ago by danno

Modified:
8 years ago

Reviewers:
Michael Starzinger, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove over-zealous hole checking in Array.slice() R=jkummerow@chromium.org BUG=chromium:165637 TEST=regress-165637.js Committed: https://code.google.com/p/v8/source/detail?r=13211

Patch Set 3 : Add --allow-natives-syntax #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -17 lines)			Patch
	M	src/builtins.cc	View		2 chunks	+17 lines, -17 lines	0 comments	Download
	A	test/mjsunit/regress/regress-165637.js	View	1 2	1 chunk	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://chromiumcodereview.appspot.com/11442054/diff/3001/test/mjsunit/regress/regress-165637.js File test/mjsunit/regress/regress-165637.js (right): https://chromiumcodereview.appspot.com/11442054/diff/3001/test/mjsunit/regress/regress-165637.js#newcode1 test/mjsunit/regress/regress-165637.js:1: // Copyright 2009 the V8 project authors. All ...

8 years ago (2012-12-12 14:28:57 UTC) #2

Michael Starzinger

8 years ago (2012-12-13 11:32:47 UTC) #3

Message was sent while issue was closed.

The regression test for this is failing on the GC Stress builder.

http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%203/build...

Expand Messages | Collapse Messages

Issue 11442054: Remove over-zealous hole checking in Array.slice() (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix whitepace #

Patch Set 3 : Add --allow-natives-syntax #

Messages