Strengthen the LayoutGrid dirtiness asserts.

Strengthen the LayoutGrid dirtiness asserts.

We should assert the grid isn't dirty in all the major accessors and also
move the dirty early out into the dirtyGrid() method instead of duplicating
it at call sites. This also adds the early out to other call sites that
were missing it.

R=ojan@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196433

[esprehn, 2015-06-03 05:04:19]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-03 05:05:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144203009/1

[commit-bot: I haz the power, 2015-06-03 07:33:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 07:33:13]

Dry run: This issue passed the CQ dry run.

[esprehn, 2015-06-03 08:46:44]

esprehn@chromium.org changed reviewers:
+ jchaffraix@chromium.org, ojan@chromium.org, svillar@igalia.com

[svillar, 2015-06-03 09:27:33]

Informally lgtm

https://codereview.chromium.org/1144203009/diff/1/Source/core/layout/LayoutGr...
File Source/core/layout/LayoutGrid.cpp (right):

https://codereview.chromium.org/1144203009/diff/1/Source/core/layout/LayoutGr...
Source/core/layout/LayoutGrid.cpp:41: class GridItemWithSpan;
Why this?

[esprehn, 2015-06-03 16:39:11]

https://codereview.chromium.org/1144203009/diff/1/Source/core/layout/LayoutGr...
File Source/core/layout/LayoutGrid.cpp (right):

https://codereview.chromium.org/1144203009/diff/1/Source/core/layout/LayoutGr...
Source/core/layout/LayoutGrid.cpp:41: class GridItemWithSpan;
On 2015/06/03 at 09:27:33, svillar wrote:
> Why this?

That class doesn't appear to be used or defined outside the cpp file. So I moved
the forward decl into it.

[ojan, 2015-06-03 21:29:50]

The CQ bit was checked by ojan@chromium.org

[ojan, 2015-06-03 21:29:51]

lgtm

[commit-bot: I haz the power, 2015-06-03 21:30:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144203009/1

[commit-bot: I haz the power, 2015-06-03 21:37:54]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196433