Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: Source/core/paint/ScrollRecorder.cpp

Issue 1144203004: Allow certain SP recorder classes to defer their "begin" operation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/paint/ScrollRecorder.h ('k') | Source/core/svg/graphics/SVGImage.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/paint/ScrollRecorder.h" 6 #include "core/paint/ScrollRecorder.h"
7 7
8 #include "platform/RuntimeEnabledFeatures.h" 8 #include "platform/RuntimeEnabledFeatures.h"
9 #include "platform/graphics/GraphicsContext.h" 9 #include "platform/graphics/GraphicsContext.h"
10 #include "platform/graphics/paint/DisplayItemList.h" 10 #include "platform/graphics/paint/DisplayItemList.h"
11 #include "platform/graphics/paint/ScrollDisplayItem.h" 11 #include "platform/graphics/paint/ScrollDisplayItem.h"
12 12
13 namespace blink { 13 namespace blink {
14 14
15 ScrollRecorder::ScrollRecorder(GraphicsContext& context, const DisplayItemClient Wrapper& client, PaintPhase phase, const IntSize& currentOffset) 15 ScrollRecorder::ScrollRecorder(GraphicsContext& context, const DisplayItemClient Wrapper& client, PaintPhase phase)
16 : m_client(client) 16 : m_client(client)
17 , m_beginItemType(DisplayItem::paintPhaseToScrollType(phase)) 17 , m_beginItemType(DisplayItem::paintPhaseToScrollType(phase))
18 , m_context(context) 18 , m_context(context)
19 , m_engaged(false)
19 { 20 {
20 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) { 21 }
21 ASSERT(m_context.displayItemList()); 22
22 if (m_context.displayItemList()->displayItemConstructionIsDisabled()) 23 ScrollRecorder::ScrollRecorder(GraphicsContext& context, const DisplayItemClient Wrapper& client, PaintPhase phase, const IntSize& currentOffset)
23 return; 24 : ScrollRecorder(context, client, phase)
24 m_context.displayItemList()->add(BeginScrollDisplayItem::create(m_client , m_beginItemType, currentOffset)); 25 {
25 } else { 26 begin(currentOffset);
26 BeginScrollDisplayItem scrollDisplayItem(m_client, m_beginItemType, curr entOffset);
27 scrollDisplayItem.replay(m_context);
28 }
29 } 27 }
30 28
31 ScrollRecorder::~ScrollRecorder() 29 ScrollRecorder::~ScrollRecorder()
32 { 30 {
31 if (!m_engaged)
32 return;
33
33 DisplayItem::Type endItemType = DisplayItem::scrollTypeToEndScrollType(m_beg inItemType); 34 DisplayItem::Type endItemType = DisplayItem::scrollTypeToEndScrollType(m_beg inItemType);
34 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) { 35 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
35 ASSERT(m_context.displayItemList()); 36 ASSERT(m_context.displayItemList());
36 if (m_context.displayItemList()->displayItemConstructionIsDisabled()) 37 if (m_context.displayItemList()->displayItemConstructionIsDisabled())
37 return; 38 return;
38 m_context.displayItemList()->add(EndScrollDisplayItem::create(m_client, endItemType)); 39 m_context.displayItemList()->add(EndScrollDisplayItem::create(m_client, endItemType));
39 } else { 40 } else {
40 EndScrollDisplayItem endScrollDisplayItem(m_client, endItemType); 41 EndScrollDisplayItem endScrollDisplayItem(m_client, endItemType);
41 endScrollDisplayItem.replay(m_context); 42 endScrollDisplayItem.replay(m_context);
42 } 43 }
43 } 44 }
44 45
46 void ScrollRecorder::begin(const IntSize& currentOffset)
47 {
48 ASSERT(!m_engaged);
49 m_engaged = true;
50
51 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
52 ASSERT(m_context.displayItemList());
53 if (m_context.displayItemList()->displayItemConstructionIsDisabled())
54 return;
55 m_context.displayItemList()->add(BeginScrollDisplayItem::create(m_client , m_beginItemType, currentOffset));
56 } else {
57 BeginScrollDisplayItem scrollDisplayItem(m_client, m_beginItemType, curr entOffset);
58 scrollDisplayItem.replay(m_context);
59 }
60 }
61
45 } // namespace blink 62 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/paint/ScrollRecorder.h ('k') | Source/core/svg/graphics/SVGImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698