Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: Source/core/paint/FloatClipRecorder.cpp

Issue 1144203004: Allow certain SP recorder classes to defer their "begin" operation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/paint/FloatClipRecorder.h ('k') | Source/core/paint/InlineTextBoxPainter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/paint/FloatClipRecorder.h" 6 #include "core/paint/FloatClipRecorder.h"
7 7
8 #include "platform/RuntimeEnabledFeatures.h" 8 #include "platform/RuntimeEnabledFeatures.h"
9 #include "platform/graphics/GraphicsContext.h" 9 #include "platform/graphics/GraphicsContext.h"
10 #include "platform/graphics/paint/DisplayItemList.h" 10 #include "platform/graphics/paint/DisplayItemList.h"
11 #include "platform/graphics/paint/FloatClipDisplayItem.h" 11 #include "platform/graphics/paint/FloatClipDisplayItem.h"
12 12
13 namespace blink { 13 namespace blink {
14 14
15 FloatClipRecorder::FloatClipRecorder(GraphicsContext& context, const DisplayItem ClientWrapper& client, PaintPhase paintPhase, const FloatRect& clipRect) 15 FloatClipRecorder::FloatClipRecorder(GraphicsContext& context, const DisplayItem ClientWrapper& client, PaintPhase paintPhase)
16 : m_context(context) 16 : m_context(context)
17 , m_client(client) 17 , m_client(client)
18 , m_clipType(DisplayItem::paintPhaseToFloatClipType(paintPhase)) 18 , m_clipType(DisplayItem::paintPhaseToFloatClipType(paintPhase))
19 { 19 {
20 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) { 20 }
21 ASSERT(m_context.displayItemList()); 21
22 if (m_context.displayItemList()->displayItemConstructionIsDisabled()) 22 FloatClipRecorder::FloatClipRecorder(GraphicsContext& context, const DisplayItem ClientWrapper& client, PaintPhase paintPhase, const FloatRect& clipRect)
23 return; 23 : FloatClipRecorder(context, client, paintPhase)
24 m_context.displayItemList()->add(FloatClipDisplayItem::create(m_client, m_clipType, clipRect)); 24 {
25 } else { 25 begin(clipRect);
26 FloatClipDisplayItem clipDisplayItem(m_client, m_clipType, clipRect);
27 clipDisplayItem.replay(m_context);
28 }
29 } 26 }
30 27
31 FloatClipRecorder::~FloatClipRecorder() 28 FloatClipRecorder::~FloatClipRecorder()
32 { 29 {
30 if (!m_engaged)
31 return;
32
33 DisplayItem::Type endType = DisplayItem::floatClipTypeToEndFloatClipType(m_c lipType); 33 DisplayItem::Type endType = DisplayItem::floatClipTypeToEndFloatClipType(m_c lipType);
34 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) { 34 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
35 ASSERT(m_context.displayItemList()); 35 ASSERT(m_context.displayItemList());
36 if (m_context.displayItemList()->displayItemConstructionIsDisabled()) 36 if (m_context.displayItemList()->displayItemConstructionIsDisabled())
37 return; 37 return;
38 m_context.displayItemList()->add(EndFloatClipDisplayItem::create(m_clien t, endType)); 38 m_context.displayItemList()->add(EndFloatClipDisplayItem::create(m_clien t, endType));
39 } else { 39 } else {
40 EndFloatClipDisplayItem endClipDisplayItem(m_client, endType); 40 EndFloatClipDisplayItem endClipDisplayItem(m_client, endType);
41 endClipDisplayItem.replay(m_context); 41 endClipDisplayItem.replay(m_context);
42 } 42 }
43 } 43 }
44 44
45 void FloatClipRecorder::begin(const FloatRect& clipRect)
46 {
47 ASSERT(!m_engaged);
48 m_engaged = true;
49
50 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
51 ASSERT(m_context.displayItemList());
52 if (m_context.displayItemList()->displayItemConstructionIsDisabled())
53 return;
54 m_context.displayItemList()->add(FloatClipDisplayItem::create(m_client, m_clipType, clipRect));
55 } else {
56 FloatClipDisplayItem clipDisplayItem(m_client, m_clipType, clipRect);
57 clipDisplayItem.replay(m_context);
58 }
59 }
60
45 } // namespace blink 61 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/paint/FloatClipRecorder.h ('k') | Source/core/paint/InlineTextBoxPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698